Skip to content

Release 2245

Choose a tag to compare

View all tags
@github-actions github-actions released this 31 Jan 11:39
2245
da829a8
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Trello card

https://trello.com/c/yOsaxN7Z

Context

There are 2 questions and that can appear on the Request school experience page, depending on whether a candidate is requesting a fixed date or flexible date.

We want to separate them, so it follows the GDS guidance on asking one question per page.

Changes proposed in this pull request

  • Separate the questions to two different pages, but keep the conditional logic the same
  • Display first the Placement Preference question and then the conditional Availability question
  • Update the content in both pages
  • Change the yaml anchors in the en.yml
    We use key merge to set the errors messages for the placement_request model, but because yaml can't handle deep merges, the attributes keys are being overridden instead of merged. Moving the anchors to the attributes keys solves that for now.

Guidance to review

Schools with fixed dates
Everything should work as expected

Schools with flex dates
The availability question should appear in a separate form right after the placement preference question. Everything else should work as expected.

Assets 2
Loading