Skip to content

Release 2271

Choose a tag to compare

View all tags
@github-actions github-actions released this 09 Feb 17:11
2271
de066af
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Trello card

https://trello.com/c/p7GIlCnK

Changes proposed in this pull request

  1. Use Google Places Autocomplete for location search: Currently, we pass user input straight to Google Geocoding, which can be problematic when dealing with ambiguous or incorrect searches.
  2. Show label on index school search: Currently, this label is hidden which is causing problems with styling. Instead, make it visible.
  3. Stop using the address_components as location name: This isn't very consistent. There are quite a few cases where the first long_name isn't very descriptive.

Guidance to review

Struggled with getting complete test coverage here, but hopefully should suffice. With JavaScript off, this will work as it does currently.

Assets 2
Loading