Skip to content

Release 2416

Choose a tag to compare

@github-actions github-actions released this 25 Mar 10:02
9cc06ea

Trello card

Trello-533

Context

We want to upgrade to Rails 7; before doing so we need to ensure we're using the Rails 6.1 defaults.

Changes proposed in this pull request

  • Load Rails 6.1 application defaults

We need to go to 6.1 defaults before we bump to Rails 7. Update load_defaults and remove the upgrade defaults config options (there's nothing that stands out as being a major issue so I'm opting to do them all in one go).

  • Fix flakey test around job retry time

The retry time we calculate is slightly off the actual retry time (due to the time it takes the test to execute). Adding a small 3 second margin of error.

  • Ensure PlacementDate has a school

We get an error on this test as the placement date does not have a school set so the initial save is failing on a DB constraint. I'm unsure why this wasn't failing before.

Guidance to review