Skip to content

Release 2626

Choose a tag to compare

View all tags
@github-actions github-actions released this 01 Sep 12:13
2626
1995ad0
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Trello card

Trello-636

Context

We have an existing feature flag rolecheck that appears to disable the role checking for the initial sign in process.

Once signed in we appear to use the Schools::DFESignInAPI::RoleCheckedOrganisations module to scope down the available schools so that the user can only access the schools that they have the GSE role enabled for in DFE sign in.

Going forward we want to disable role checking, so that a user will have access to the GSE application if they have access to that school within DFE sign in (removing the need to get a second stage of approval for using the GSE app).

Changes proposed in this pull request

  • Disable role checking via rolecheck feature flag

Re-purpose rolecheck feature flag; when disabled (which it is on all environments currently) users will not need the GSE service role in order to access a school; they will only need to be assigned to the school in DFE sign in.

Guidance to review

It's a bit tricky to review, but essentially you need to request access to a new school in preprod and have your request approved. It should then appear in the school switcher menu and allow access without getting the School Experience role setup for that school. I've done this in preprod and verified it worked as expected.

Assets 2
Loading