Skip to content

Release 2663

Choose a tag to compare

@github-actions github-actions released this 04 Oct 08:59
0ca0ee2

Trello card

Trello-606

Context

We currently only allow a single rejection reason for a placement request, however we want to allow candidates to specify multiple reasons.

Changes proposed in this pull request

  • Allow multiple reasons for a placement rejection

Add attributes/columns for each available rejection category. Populate new attributes from the existing, single attribute as part of the migration.

Retain the original rejection_category attribute and ensure it stays up to date (so when the categories change we pick the latest to populate this attribute) -- assuming we don't need to revert it can later be removed.

Update analytics whitelist to include the new attributes.

Guidance to review

To test this you need to sign up for a placement at a school then sign in as the school and choose to reject the placement request; you should then be able to select multiple reasons.

Currently wherever we rendered the single reason for rejection (on views/emails) we now display all reasons in the same sentence (separated by periods), i.e. Reason one. Reason two. Reason three. etc.

Form Preview Email View Rejected Request
screencapture-localhost-3000-schools-placement-requests-2-cancellation-new-2022-09-08-13_32_57 Screenshot 2022-09-30 at 16 00 01 Screenshot 2022-09-30 at 16 00 29 Screenshot 2022-09-30 at 16 01 02

Once this is deployed and we're happy its behaving I'll raise a follow up PR to remove the redundant rejection_category attribute.