Release 3310
Trello card
Context
The rubocop-govuk update involved breaking changes related to other dependencies which meant tests were failing. The rubocop-govuk bump was originally part of this dependabot update.
Changes proposed in this pull request
- bumped
rubocop-govukto 5.0.2. - installed
gem 'rubocop-capybara', '~> 2.21',gem 'rubocop-factory_bot', '~> 2.26',gem 'rubocop-rspec', '~> 3.2' - updated
.rubocop.ymlfile. - created a
.rubocop_todo.ymllist for linting errors; the past offences will now be ignored by Rubocop, therefore all tests are currently passing. Question as to how/when to address these errors in future (due to the nature/age of GSE, there are over 6,000 offences at present).
Guidance to review
- we could not run rubocop autocorrect as this caused issues with rspec and cucumber tests.