Skip to content

v50686-stable: Merge pull request #1391 from DFE-Digital/feature/2116/approval-request

Pre-release
Pre-release

Choose a tag to compare

View all tags
released this 09 Mar 17:06
v50686-stable
a5d9976
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Changes:

  • a5d9976 Merge pull request #1391 from DFE-Digital/feature/2116/approval-request
  • 68e74d0 Merge remote-tracking branch 'origin/master' into feature/2116/approval-request
  • dd7d4d2 Fixed cucumber specs
  • 0710671 Merge pull request #1402 from DFE-Digital/maintenance/fix-lint-unreliability-in-ci
  • 7cffd77 Dont actually require rubocop
  • fd99fc7 Fixed up features to comply with rubocop rules
  • 6f855ff Enabled new cops
  • e9a8aac Removed use of instance variables in helpers
  • be6dc12 Removed usage of .html_safe
  • 58fdb6f Assorted small syntactic fixes for Rubocop compliance
See More
  • 5e382bd Array of strings fixes
  • a79c27c Disabled Cop for legacy find_by_* since we have methods following that pattern
  • b1e912e Pluralisation fixes
  • 80ed3d3 Explicitly specify values for enums
  • 29451b1 Use if ...blank? instead of unless ...present?
  • 51deb73 Fixed missing :dependent on HasMany relationships
  • 7356996 Fixed duplicate association
  • 01575c4 Added missing inverse_of associations
  • a7482cb Taught rubocop about servertest environment
  • 98c8a3c Replaced usage of Date.today with Time.zone.today
  • 279cb10 Fixes for lib/
  • 448240e Made Rails/FilePath handling consistent across app
  • 215f044 Switched from govuk-lint to rubocop-govuk
  • d9a5e3a Merge pull request #1400 from DFE-Digital/maintenance/gem-updates-03-2020
  • 8f27475 Merge pull request #1346 from DFE-Digital/bugfix/attempt-selenium-upgrade
  • d2424d5 Nokogiri plus other gems
  • 751cb24 Merge pull request #1383 from DFE-Digital/dependabot/bundler/master/brakeman-4.8.0
  • 37b3e1e Bump brakeman from 4.7.2 to 4.8.0
  • 8828ef0 Merge pull request #1254 from DFE-Digital/feature/control-feature-flags-from-env-var
  • 97cbef6 Merge pull request #1395 from DFE-Digital/dependabot/bundler/master/bootsnap-1.4.6
  • 1a37ac6 Changed button label for clarity
  • 95cede9 Handle no school chosen, no school available, and no role situations properly
  • db1da08 Updated schools changer to give user options when no schools available
  • 4cc5b6f Added button for 'add organisation' to Change school screen
  • e7d49d6 Bump bootsnap from 1.4.5 to 1.4.6
  • 877c3d3 Disabled Cucumber features using mocks for 'real server' runs
  • 028688f Added cucumber specs for Sign in with school chooser
  • f5d5535 Added missing spec for SchoolChange model
  • 70f9fa5 Use SchoolChange to determine feature enablement in specs
  • 79d4660 Use internal school chooser instead of DfE Sign-in when its enabled
  • 537b45b Removed ability to use org list without role check
  • 7e3321b Ensure school is in list of acceptable UUIDs
  • d49a5e4 Move DfE Sign-in role check to the ChangeSchool model
  • fe48075 Switched to using School Urn instead of School Id
  • 3484f76 Allow choosing School without already having a URN set
  • 22a452e Allow comma separated feature flags
  • 7ee56c2 Allow adding feature flags from FEATURE_FLAGS env var
  • ea06d2d Small refactor ChangeSchoolsControllerSpec specs
  • c45d7d2 Redirect to change school automatically if no URN set
  • ed8b037 Retrieve and store map of Sign-in org uuids => URNs
  • b182de4 Attempted upgrade of Selenium to 3.141.59-zinc

This list of changes was auto generated.

Assets 2
Loading