Fix issue where disabled squads were treated as enabled #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of the training_squad state was being ignored, despite being used by the ui to distinguish between being enabled, or being disabled. This caused later disabled squads to remain in the pool of training squads.
NicksWorld
force-pushed
the
fix/autotraining_disable
branch
from
7f62096 to
85d92f1
Compare
ab9rf
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of the training_squad state was being ignored, despite being used by the ui to distinguish between being enabled, or being disabled. This caused later disabled squads to remain in the pool of training squads.
The change now has the squads treated as disabled, and promptly deleted from the persistent state if disabled by the ui.