Update assign-preferences.lua #335
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some food categories, this script saves the mat_state wrong. That is, differently from how the game does it. Dunno if it has any actual effect, apart from Dwarf Therapist showing it in detail. Might actually even be that mat_state should outright be 0, as even drinks don't seem to have 1 for them. Just start a new embark and look at the preferences of your starting seven with gm-editor or something, I could post screenshots of examples but it should be easy to see for yourself.
Member
|
is this PR still a draft, or is it ready for review? |
Member
|
removing from project for now; waiting on response from author |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some food categories, this script saves the mat_state wrong. That is, differently from how the game does it. Dunno if it has any actual effect, apart from Dwarf Therapist showing it in detail. Might actually even be that mat_state should outright be 0, as even drinks don't seem to have 1 for them.
Just start a new embark and look at the preferences of your starting seven with gm-editor or something, I could post screenshots of examples but it should be easy to see for yourself.