Randomized caste for modtools/transform-unit #353
Conversation
This randomizes the caste if either the -caste argument is omitted or if the given caste isn't found
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
I think using a random caste is good when none is specified, but if a caste is specified but not found, the script should throw an error.
|
|
||
| if not caste then | ||
| error 'Invalid caste.' | ||
| local rand_caste = math.random( 0, math.abs(#race.caste-1) ) |
There was a problem hiding this comment.
Could you write a unit test to show coverage of the case where race.caste has no elements? See the test/ dir for sample unit tests.
| error 'Invalid caste.' | ||
| local rand_caste = math.random( 0, math.abs(#race.caste-1) ) | ||
| if not race.caste[rand_caste] then | ||
| error 'Creature has no castes or non have been found' |
| local rand_caste = math.random( 0, math.abs(#race.caste-1) ) | ||
| if not race.caste[rand_caste] then | ||
| error 'Creature has no castes or non have been found' | ||
| else |
There was a problem hiding this comment.
No need to have an else clause if the if clause throws an error. Just replace the else with an end and let the assignment happen unconditionally.
myk002
changed the title
|
I updated the title of the PR to track the status. Could you remove the |
myk002
changed the title
|
@Bagelboi do you have time to address the review comments? |
|
ping on this |
|
waiting on response from author |
2 participants
This randomizes the caste if either the -caste argument is omitted or if the given caste isn't found