Disable credit card payment option #2582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Block credit card payments in PaymentInfoService with clear error message - Add PAYMENT_METHOD_NOT_ALLOWED to QuoteError enum - Return error early in TransactionHelper for card payment quotes - Remove obsolete card-specific validation checks
TaprootFreak
force-pushed
the
develop
branch
from
d06a5a8 to
b4b852e
Compare
davidleomay
approved these changes
Jan 8, 2026
Resolve conflicts: - quote-error.enum.ts: Keep PAYMENT_METHOD_NOT_ALLOWED (card payments disabled) - transaction-helper.ts: Remove card-specific checks (now blocked early)
🤖 PR Review Bot
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PaymentInfoServicewith clear error messagePAYMENT_METHOD_NOT_ALLOWEDtoQuoteErrorenum for quote requestsTransactionHelperfor card payment quotesImportant
Bitte diesen PR nur prüfen, noch nicht mergen. Dieser PR dient als Vorbereitung und soll zunächst nur reviewed werden.
Test plan
PaymentMethodNotAllowedfor card payments