Add Liechtenstein bank holidays 2026 and prevent fiat output on holidays #2779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add liechtenstein-bank-holiday.config.ts with 2026 holidays - Update fiat-output-job.service to check for LI/CH bank holidays - Block isReadyDate on bank holidays and day before after 16:00
- Bank holiday blocking now only applies to Liechtenstein IBANs - CH and other IBANs are not affected by holiday checks - Remove unused isBankHoliday import
- Bank holiday blocking now only applies to FiatOutputs with type LiqManagement - Other types (BuyFiat, BuyCryptoFail, etc.) are not affected
- Add verbose logging when FiatOutput is blocked due to bank holiday - Use early return (continue) for better readability - Only calculate isAfter16 when actually needed (performance) - Clearer variable scoping and logic flow
Yannick1712
reviewed
Jan 1, 2026
src/subdomains/supporting/fiat-output/fiat-output-job.service.ts
Outdated
Show resolved
Hide resolved
src/subdomains/supporting/fiat-output/fiat-output-job.service.ts
Outdated
Show resolved
Hide resolved
src/subdomains/supporting/fiat-output/fiat-output-job.service.ts
Outdated
Show resolved
Hide resolved
- Remove unused getLiechtensteinBankHolidayInfoBanner function and import - Simplify holiday check: combine conditions with || operator - Remove unnecessary intermediate variables (isLiIban, isLiqManagement, etc.) - Use single logger.verbose message for bank holiday blocking
TaprootFreak
force-pushed
the
feature/liechtenstein-bank-holidays-2026
branch
from
5746458 to
d3eff8d
Compare
Yannick1712
approved these changes
Jan 1, 2026
Comment on lines
+3
to
+20
| export const LiechtensteinBankHolidays = [ | ||
| '2026-01-01', | ||
| '2026-01-02', | ||
| '2026-01-06', | ||
| '2026-04-06', | ||
| '2026-05-01', | ||
| '2026-05-14', | ||
| '2026-05-25', | ||
| '2026-06-04', | ||
| '2026-08-15', | ||
| '2026-09-08', | ||
| '2026-11-01', | ||
| '2026-12-08', | ||
| '2026-12-24', | ||
| '2026-12-25', | ||
| '2026-12-26', | ||
| '2026-12-31', | ||
| ]; |
Member
There was a problem hiding this comment.
Not sure if we should export the data in a separated csv? @davidleomay
Collaborator
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
liechtenstein-bank-holiday.config.tswith all 2026 Liechtenstein bank holidaysfiat-output-job.service.tsto check Liechtenstein bank holidays for LI IBANs with type LiqManagementTest plan