Fix sell deposit tx creation with missing user address #2785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation
Two bugs were causing 'Failed to create deposit transaction: invalid address or ENS name':
1. In toPaymentInfoDto(): The transactionRequest only contained user: { id: userId }
without the address field. Fixed by explicitly passing user.address.
2. In depositTx controller endpoint: getById() did not load the deposit relation,
so route.deposit was undefined. Fixed by adding relations: { deposit: true }.
Also added validation to throw clear errors if address or deposit is missing.
TaprootFreak
force-pushed
the
fix/sell-deposit-tx-user-address
branch
from
c252d4a to
33e4049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix two bugs causing "Failed to create deposit transaction: invalid address or ENS name" error.
Root Cause
Bug 1: Missing user address in toPaymentInfoDto
In
toPaymentInfoDto(), after callingtransactionRequestService.create(), the returnedtransactionRequestonly containsuser: { id: userId }without theaddressfield. WhencreateDepositTx()tried to accessrequest.user.address, it wasundefined.Fix: Add optional
userAddressparameter tocreateDepositTx()and passuser.addressfrom the already-loaded user object.Bug 2: Missing deposit relation in controller
In the
depositTxcontroller endpoint,getById()was called without loading thedepositrelation. This causedroute.depositto beundefined, resulting in the same error when accessingroute.deposit.address.Fix: Add
relations: { deposit: true }to thegetById()call.Changes
sell.service.ts: Add optionaluserAddressparameter, validation for missing addressessell.controller.ts: Loaddepositrelation ingetById()callTest plan
/paymentInfos/:id/txendpoint works correctly