Skip to content

Improve circular dependency fix #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidleomay merged 4 commits into from
Jan 15, 2026
Merged

Improve circular dependency fix #2945

davidleomay merged 4 commits into from
Jan 15, 2026

Conversation

@davidleomay
Copy link
Member

@davidleomay davidleomay commented Jan 15, 2026

Release Checklist

Pre-Release

  • Check migrations
    • No database related infos (sqldb-xxx)
    • Impact on GS (new/removed columns)
  • Check for linter errors (in PR)
  • Test basic user operations (on DFX services)
    • Login/logout
    • Buy/sell payment request
    • KYC page

Post-Release

  • Test basic user operations
  • Monitor application insights log

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

⚠️ Non-Conventional Commits (1)

The following commits don't follow conventional commit format:

  • 51c6982 Merge branch 'develop' into fix/circular-dependency

Expected: type(scope): description
Types: feat, fix, refactor, test, ci, docs, chore, perf, style, build, revert

⚠️ Security: 0 critical, 61 high vulnerabilities

@davidleomay davidleomay merged commit 01ad0f1 into develop Jan 15, 2026
7 checks passed
@davidleomay davidleomay deleted the fix/circular-dependency branch January 15, 2026 11:20
@github-actions github-actions bot mentioned this pull request Jan 15, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaprootFreak TaprootFreak Awaiting requested review from TaprootFreak TaprootFreak is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidleomay