Release: develop -> main #2986
Merged
Release: develop -> main #2986
+82
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix BankTx type classification for LIQ_MANAGEMENT transactions Previously, all LIQ_MANAGEMENT FiatOutput transactions were blindly set to BankTxType.INTERNAL, overriding more specific types like SCRYPT, KRAKEN, or SCB based on the counterparty name. Add getSpecificType() method to check the BankTx name and assign the correct type (SCRYPT for Scrypt Digital Trading, KRAKEN for Payward Trading, SCB for SCB AG) before falling back to INTERNAL. * Remove INTERNAL fallback - only set specific types (Scrypt/Kraken/SCB) * Add migration to fix existing Scrypt transactions typed as Internal * Extend migration to also fix Kraken and SCB transactions * Refactor: reuse getType() from BankTxService instead of duplicating logic
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
TaprootFreak
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist