Skip to content

feat: custody fixes + history#3162

Merged
davidleomay merged 6 commits intodevelopfrom
feat/custody-history
May 7, 2026
Merged

feat: custody fixes + history#3162
davidleomay merged 6 commits intodevelopfrom
feat/custody-history

Conversation

@davidleomay
Copy link
Copy Markdown
Member

Release Checklist

Pre-Release

  • Check migrations
    • No database related infos (sqldb-xxx)
    • Impact on GS (new/removed columns)
  • Check for linter errors (in PR)
  • Test basic user operations (on DFX services)
    • Login/logout
    • Buy/sell payment request
    • KYC page

Post-Release

  • Test basic user operations
  • Monitor application insights log

Copy link
Copy Markdown
Member Author

@davidleomay davidleomay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix rounding issues:
  // custody-asset-balance-dto.mapper.ts:30
  balance: Util.floorReadable(balance, AmountType.ASSET),

# Conflicts:
#	src/subdomains/core/custody/services/custody-job.service.ts
#	src/subdomains/core/custody/services/custody-order.service.ts
@davidleomay davidleomay marked this pull request as ready for review May 7, 2026 16:33
@davidleomay davidleomay requested a review from TaprootFreak as a code owner May 7, 2026 16:33
@davidleomay davidleomay merged commit d8cbec1 into develop May 7, 2026
7 checks passed
@davidleomay davidleomay deleted the feat/custody-history branch May 7, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant