Fix toScrypt/fromScrypt pending balance for Olkypay EUR#3236
Merged
TaprootFreak merged 2 commits intodevelopfrom Feb 21, 2026
Merged
Fix toScrypt/fromScrypt pending balance for Olkypay EUR#3236TaprootFreak merged 2 commits intodevelopfrom
TaprootFreak merged 2 commits intodevelopfrom
Conversation
The pending balance calculation for Scrypt transfers only checked yapealEurBank.iban, causing a mismatch for Olkypay/EUR assets whose IBAN is the Olky bank. This resulted in phantom pending amounts (~620k EUR) inflating the total balance. Add parallel Olky IBAN lookups for all four EUR Scrypt pending calculations (toScrypt filtered/unfiltered, fromScrypt filtered/ unfiltered) and include them in the respective sums. No double-counting occurs because isBankMatching returns true for exactly one bank per asset.
Yannick1712
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toScryptbecause the minus-side calculation only checkedyapealEurBank.iban, which doesn't match Olky assetsolkyBank.ibanlookups for all four EUR Scrypt pending calculations (toScrypt filtered/unfiltered, fromScrypt filtered/unfiltered) and included them in the sumsisBankMatchingreturns true for exactly one bank per asset (Olkypay/EUR → olkyBank, Yapeal/EUR → yapealEurBank)Test plan
toScryptpending for Olkypay/EUR is ~0 instead of ~620kfromScrypt/toScryptfiltered matches unfiltered (no anomalies)