fix: round Firo balance to prevent floating-point errors#3261
Merged
fix: round Firo balance to prevent floating-point errors#3261
Conversation
Summing UTXO amounts with reduce() can accumulate IEEE 754 rounding errors (e.g. 64.07538018000001 instead of 64.07538018). Apply roundAmount() to the result, consistent with all other amount calculations in the client.
davidleomay
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FiroClient.getBalance()where summing UTXO amounts viareduce()produces values like64.07538018000001instead of64.07538018roundAmount()(8 decimal places) to the result, consistent with all other amount calculations in the clientTest plan