Skip to content

feat: address change with document upload and manual review#3373

Merged
TaprootFreak merged 2 commits intoDFXswiss:developfrom
TaprootFreak:feature/change-address-endpoint
Mar 9, 2026
Merged

feat: address change with document upload and manual review#3373
TaprootFreak merged 2 commits intoDFXswiss:developfrom
TaprootFreak:feature/change-address-endpoint

Conversation

@TaprootFreak
Copy link
Collaborator

@TaprootFreak TaprootFreak commented Mar 9, 2026

Summary

  • Move address change from direct endpoint to KYC flow with document upload and admin approval
  • Users submit address proof file via PUT /kyc/data/address/:id, which goes through manual review before the address is updated
  • On admin approval, address is written to userData with country validation, transliteration, and Sift update

Changes

  • KycChangeAddressData: add file (Base64) and fileName fields
  • FileType: add ADDRESS_CHANGE
  • KycController: add PUT /kyc/data/address/:id endpoint
  • KycService: add updateAddressChangeData() (upload + manual review) and completeAddressChange() (apply address on approval)
  • KycAdminService: add ADDRESS_CHANGE case in completion hook
  • KycStep: change ADDRESS_CHANGE sessionInfo from NONE to API URL
  • UserDataService: add updateUserAddress() with country validation, transliteration, Sift update

Test plan

  • Verify PUT /kyc/data/address/:id accepts Base64 file + fileName + address payload
  • Verify uploaded file is stored in Azure as AddressChange FileType
  • Verify KYC step transitions to MANUAL_REVIEW after upload
  • Verify admin approval via PUT /kyc/admin/step/:id triggers address update in userData
  • Verify admin rejection sends failure notification
  • Verify country validation rejects disabled countries
  • Verify Sift billing address update is sent on completion
  • Verify build, lint, and format checks pass

Add CHANGE_ADDRESS mechanism analogous to CHANGE_PHONE, allowing users
to update their personal address at any time without KYC level checks.
Move address change from direct PUT /user/address endpoint to KYC flow
with document upload and admin approval. Users now submit an address
proof file via PUT /kyc/data/address/:id, which goes through manual
review before the address is actually updated.
@TaprootFreak TaprootFreak changed the title feat: add PUT /user/address endpoint for personal address changes feat: address change with document upload and manual review Mar 9, 2026
@TaprootFreak TaprootFreak marked this pull request as ready for review March 9, 2026 10:28
@TaprootFreak TaprootFreak merged commit 352d0e1 into DFXswiss:develop Mar 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants