Merged
Conversation
* feat: add Ark (Arkade) blockchain integration Add full Ark protocol support as a Bitcoin L2 (coin-only), using the @arkade-os/sdk with Arkadeos server (arkade.computer). Follows the same pattern as the existing Spark integration. Env vars: ARK_PRIVATE_KEY, ARK_SERVER_URL (optional) * fix: remove dead reconnectWallet code and improve tx confirmation logic - Remove unused reconnectWallet() and reconnectAttempt field - Improve getTransaction() to use finalizePendingTxs() for outgoing tx confirmation instead of only checking VTXOs * fix: add Jest mock for @arkade-os/sdk to fix CI test failures The @arkade-os/sdk ships ESM-only sub-dependencies (@scure/btc-signer) that break Jest's CommonJS transform. Add a moduleNameMapper mock following the existing @dfinity pattern. * fix: add missing Ark integration points in crypto service, balance adapter, and user enum Add ARK cases for payment requests, address detection, signature verification, and balance updates that were missed in the initial integration. * test: add unit tests for ArkClient and ArkService Cover signature verification (valid/invalid/edge cases), balance conversion, transaction lifecycle, health checks, payment request formatting, and not-implemented guards. * fix: add Ark explorer URLs and fix missing Spark/Ark in addressPaths and assetPaths - Set Ark explorer to https://explorer.arkade.sh with tx path - Add Spark and Ark to addressPaths switch (fixes broken address explorer links for Spark, enables them for Ark) - Add Spark and Ark to assetPaths switch for completeness Closes #3400 * feat: add migration to seed Ark/BTC asset Add database migration that inserts BTC as a Coin asset on the Ark blockchain, referencing the existing Kraken BTC/USDT price rule (id 11), consistent with Bitcoin/BTC and Lightning/BTC. * refactor: extract shared Bech32mService base class from Spark/Ark services Eliminate duplicated signature verification, payment request, and address helper methods by introducing an abstract Bech32mService. Fix any-types in sendSignedTransaction for Spark/Ark clients. --------- Co-authored-by: Bernd <bernd@dfx.swiss>
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
…firmations (#3415) Co-authored-by: max-tech-bot <max-tech-bot@users.noreply.github.com>
…3418) The identity key is not directly embedded in offchainAddr payloads (which contain version + serverPubKey + vtxoTaprootKey). Override verifySignature in ArkService to recover the identity key from the signature, re-derive the DefaultVtxo taproot scripts, and compare the tweaked public key against the address.
* [NOTASK] dfxApproval merge refactoring * [NOTASK] Refactoring * [NOTASK] Refactoring 2
…ication (#3420) * fix: support DelegateVtxo and server timelocks in Ark signature verification The initial Ark offchainAddr verification only tried DefaultVtxo.Script with the default 144-block timelock. Real wallets using arkade.computer use a 605184-second server timelock and delegation via delegate.arkade.money, producing DelegateVtxo addresses with 3 taproot leaves instead of 2. - Fetch ASP server's unilateralExitDelay and try both default and server timelocks - Fetch delegate pubkeys and try DelegateVtxo.Script in addition to DefaultVtxo - Cache server info to avoid repeated network calls - Update Jest mock with BIP68 timelock encoding and DelegateVtxo support - Add tests for server-timelock and DelegateVtxo address verification * style: fix prettier formatting
TaprootFreak
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist