fix: include blockchain fees in totalMinus calculation#3442
Merged
TaprootFreak merged 1 commit intodevelopfrom Mar 16, 2026
Merged
fix: include blockchain fees in totalMinus calculation#3442TaprootFreak merged 1 commit intodevelopfrom
TaprootFreak merged 1 commit intodevelopfrom
Conversation
The getChangeLog() method excluded blockchain fees (cryptoInputFee, payoutOrderFee, tradingOrderFee) from totalMinus, causing the net total on the financial dashboard to be overstated. Also expose bank and kraken expense categories in the changes DTO for full transparency. Refs #3438
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
totalBlockchainFeewas never included intotalMinusingetChangeLog()(since DEV-3275, Oct 2024), causing the Net Total on the Financial Log dashboard to be overstatedbankandkrakenexpense categories in the financial changes API response for full transparencyChanges
log-job.service.tsfinancial-log.dto.ts+dashboard-financial.service.tsbank: numberandkraken: { total, withdraw, trading }to theminusobject inFinancialChangesEntryDtomapChangesLogToEntry()Test plan
bankandkrakenfieldsminus.totalnow equalsref + binance + blockchain + bank + krakentotalequalsplus.total - minus.totalCloses #3438