Add EUR bank percent fee with separate fee breakdown#3448
Merged
TaprootFreak merged 1 commit intodevelopfrom Mar 18, 2026
Merged
Add EUR bank percent fee with separate fee breakdown#3448TaprootFreak merged 1 commit intodevelopfrom
TaprootFreak merged 1 commit intodevelopfrom
Conversation
- Add bankFixed and bankPercent fields to FeeDto for separate display - Keep existing bank field as sum for backwards compatibility - Add migration to insert new Bank fee: 0.5% for EUR transactions - Return null for bankFixed/bankPercent on historical transactions
This was referenced Mar 17, 2026
davidleomay
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bankFixedandbankPercentfields toFeeDtoAPI response for separate displaybankfield remains as sum (backwards compatible)nullfor the new breakdown fieldsChanges
FeeDto— new optional fieldsbankFixed,bankPercentcalculateTotalFee()— compute and return breakdowngetTargetEstimation()/getTxFeeInfos()— propagate new fieldsTransactionDtoMapper.mapFees()— returnnullfor historical data1773700400000-AddEurBankPercentFee— insert new Bank fee rowTest plan
bankFixedandbankPercentare separate in responsebankPercentis 0 (no EUR fee)bankFixedandbankPercentare null for old transactionsbankfield still equalsbankFixed + bankPercent