Skip to content

Add EUR bank percent fee with separate fee breakdown#3448

Merged
TaprootFreak merged 1 commit intodevelopfrom
feature/add-eur-bank-percent-fee
Mar 18, 2026
Merged

Add EUR bank percent fee with separate fee breakdown#3448
TaprootFreak merged 1 commit intodevelopfrom
feature/add-eur-bank-percent-fee

Conversation

@TaprootFreak
Copy link
Collaborator

Summary

  • Add new Bank fee: 0.5% on all EUR bank payments (migration, fiat id 2)
  • Add bankFixed and bankPercent fields to FeeDto API response for separate display
  • Existing bank field remains as sum (backwards compatible)
  • Historical transactions return null for the new breakdown fields

Changes

  • FeeDto — new optional fields bankFixed, bankPercent
  • calculateTotalFee() — compute and return breakdown
  • getTargetEstimation() / getTxFeeInfos() — propagate new fields
  • TransactionDtoMapper.mapFees() — return null for historical data
  • Migration 1773700400000-AddEurBankPercentFee — insert new Bank fee row

Test plan

  • Verify migration runs on staging
  • GET /buy/quote with EUR input — confirm bankFixed and bankPercent are separate in response
  • GET /buy/quote with CHF input — confirm bankPercent is 0 (no EUR fee)
  • GET /history — confirm bankFixed and bankPercent are null for old transactions
  • Verify bank field still equals bankFixed + bankPercent

- Add bankFixed and bankPercent fields to FeeDto for separate display
- Keep existing bank field as sum for backwards compatibility
- Add migration to insert new Bank fee: 0.5% for EUR transactions
- Return null for bankFixed/bankPercent on historical transactions
@TaprootFreak TaprootFreak merged commit b326a60 into develop Mar 18, 2026
8 checks passed
@TaprootFreak TaprootFreak deleted the feature/add-eur-bank-percent-fee branch March 18, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants