Open
Conversation
* Add full Firo Spark address support Add Spark address recognition (sm1...), signature verification via verifymessagewithsparkaddress RPC, and mintSpark payouts. Split payout strategy into Spark/transparent groups. Filter deposit UTXOs from spending. Add OCP payment TxId fallback for Spark wallets that cannot export signed hex. Move TX size constants to config. * Address PR review: use Util.retry, accept overpayment, avoid double UTXO fetch - Replace manual retry loop with Util.retry in doFiroTxIdPayment - Only fail on underpayment, accept overpayment for Firo TX ID payments - Avoid double UTXO fetch in getBalance and sendMany via getNonDepositUtxos - Update tests for new error handling and add overpayment test case * Add Firo Spark address tests to CryptoService specs - Test blockchain detection for sm1 Spark addresses → Blockchain.FIRO - Test address type detection for transparent → FIRO and Spark → FIRO_SPARK
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
Firo supports both signed hex (Electrum) and txId (Campfire/Spark) submission, but the hint only described the hex flow. This was misleading for Spark wallet users who broadcast transactions themselves.
* [DEV-3957] partner fee * [DEV-3957] add partnerFeeAmount * [DEV-3957] find partnerFee in default * [DEV-3957] fix dev build * [DEV-3957] Renaming to platform fee * [DEV-3957] fix build * [DEV-3957] add migration * [DEV-3957] Refactoring (#2534) * [DEV-3957] partner fee payout * [DEV-3957] add partnerRef cols * [DEV-3957] Fixed tests * [DEV-3957] Refactoring 2 * [DEV-3957] Refactoring 3 * [DEV-3957] adapt migration * [DEV-3957] fix build * [DEV-3957] fix small bugs * fix: set new bank fee fields in DTO * feat: bank fee split * feat: renaming + migration * chore: rename * fix: format --------- Co-authored-by: David May <85513542+davidleomay@users.noreply.github.com> Co-authored-by: David May <david.leo.may@gmail.com>
* feat: add GET brokerbot/sellPrice and GET brokerbot/sellShares endpoints. * feat: use user-specific-fee for calculation instead of default. * chore: rename GET brokerbot/shares to brokerbot/buyShares. * test: add FeeService. * refactor: update datatype for pricePerShare and totalPrice to number instead of string.
Author
❌ TypeScript: 6 errors |
* refactor: separate verified and unverified TxId payment flows Split TxIdBlockchains into UnverifiedTxIdBlockchains (Monero, Zano, Tron, Cardano) and VerifiedTxIdBlockchains (Solana, ICP). Verified blockchains now use doVerifiedTxIdPayment with tx confirmation retry via extracted waitForTxConfirmation helper. * refactor: add separate config key for tx confirmation retry count
FeeInfo no longer has direct rate/fixed properties — access dfx, bank, and partner FeeSpec fields instead.
* [NOTASK] partnerFee refactoring * [NOTASK] prettier fix
* [NOTASK] phoneCall Refactoring * [NOTASK] Mail text refactoring * [NOTASK] small fix
* feat: improve custody order list entry DTO - Rename userId to userDataId for clarity - Return updated timestamp instead of created - Use TransactionRequest amount as fallback for input/output amounts * fix: set inputAsset on SWAP and SEND custody orders * fix: remove input asset on send
3 tasks
* [NOTASK] refReward refactoring * [NOTASK] kyc refactoring * fix: input amount calculation with min fee * [NOTASK] remove unused code * fix: custody order amount fallback --------- Co-authored-by: David May <david.leo.may@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist