Skip to content

feat: add reason field to recall entity#3604

Merged
TaprootFreak merged 2 commits intodevelopfrom
feat/recall-reason
Apr 23, 2026
Merged

feat: add reason field to recall entity#3604
TaprootFreak merged 2 commits intodevelopfrom
feat/recall-reason

Conversation

@TaprootFreak
Copy link
Copy Markdown
Collaborator

Summary

  • Adds mandatory reason field to newly created recalls using SEPA ISO 20022 reason codes
  • Enum values: DUPL, TECH, FRAD, CUST, AM09, AC03, Unknown (fallback)
  • DB column is nullable — existing recalls keep NULL, only new creates via CreateRecallDto are required to pass a reason
  • UpdateRecallDto accepts reason as optional-but-not-null

Test plan

  • Run migration 1776930994259-AddRecallReason on DEV, verify column exists as nvarchar(256) nullable
  • POST /recall without reason → 400 validation error
  • POST /recall with valid enum value → 201, row persisted with reason
  • POST /recall with invalid enum value → 400 validation error
  • PUT /recall/:id updating only reason → row updated, other fields untouched
  • Verify existing recalls (reason = NULL) are still readable

Adds mandatory reason field to newly created recalls using SEPA
ISO 20022 reason codes (DUPL, TECH, FRAD, CUST, AM09, AC03) plus
Unknown as fallback. Existing recalls keep NULL (column nullable).
@TaprootFreak TaprootFreak merged commit fc18949 into develop Apr 23, 2026
7 checks passed
@TaprootFreak TaprootFreak deleted the feat/recall-reason branch April 23, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants