feat: include BankTxReturn and BankTxRepeat in compliance search (name + IBAN)#3615
Merged
TaprootFreak merged 2 commits intodevelopfrom Apr 23, 2026
Merged
Conversation
davidleomay
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compliance search (
GET /support?key=<...>) now also surfaces completed-but-still-name-bearing bank_tx rows — both on name and IBAN/virtualIBAN lookups.Covered types (additional)
BankTxReturn— original credit that was later returned to senderBankTxRepeat— original credit that was re-sent / duplicatedExposed via new exported constant
BankTxComplianceSearchableTypes = [...BankTxUnassignedTypes, BANK_TX_RETURN, BANK_TX_REPEAT].Changes
bank-tx.entity.ts: new exportedBankTxComplianceSearchableTypes.bank-tx.service.ts:getBankTxsByName→ uses the new constant (was inline spread incl. onlyBANK_TX_RETURN).getUnassignedBankTx→ new optionaltypesparam (default =BankTxUnassignedTypes), so the user-facing/transaction/unassignedendpoint is unaffected.support.service.ts: IBAN/virtualIBAN branch passesBankTxComplianceSearchableTypeswhen callinggetUnassignedBankTx.Motivation
Already-returned or repeated deposits were invisible in compliance search, even though the sender's name/IBAN is still on the record. Example: bank_tx 156149 (MEEKERS MARCEL JOHANNES, returned 01.07.2025) — not findable by name until now.
Scope notes
BANK_TX_RETURN_CHARGEBACKintentionally not included (scope decision)./transaction/unassignedbleibt unverändert (type default unchanged).Test plan
MEEKERS MARCEL JOHANNES→ bank_tx 156149 (type=BankTxReturn) must appear inbankTxlist.BankTxRepeatcredit → must appear.Pendingtx → still found (regression check).BankTxReturn/BankTxRepeat→ must appear.GET /transaction/unassigned(customer view) → still onlyGSheet/Unknown/Pending(no regression, no returns shown to customers).