Skip to content

feat: include BankTxReturn and BankTxRepeat in compliance search (name + IBAN)#3615

Merged
TaprootFreak merged 2 commits intodevelopfrom
feat/compliance-name-search-include-returns
Apr 23, 2026
Merged

feat: include BankTxReturn and BankTxRepeat in compliance search (name + IBAN)#3615
TaprootFreak merged 2 commits intodevelopfrom
feat/compliance-name-search-include-returns

Conversation

@TaprootFreak
Copy link
Copy Markdown
Collaborator

@TaprootFreak TaprootFreak commented Apr 23, 2026

Summary

Compliance search (GET /support?key=<...>) now also surfaces completed-but-still-name-bearing bank_tx rows — both on name and IBAN/virtualIBAN lookups.

Covered types (additional)

  • BankTxReturn — original credit that was later returned to sender
  • BankTxRepeat — original credit that was re-sent / duplicated

Exposed via new exported constant BankTxComplianceSearchableTypes = [...BankTxUnassignedTypes, BANK_TX_RETURN, BANK_TX_REPEAT].

Changes

  • bank-tx.entity.ts: new exported BankTxComplianceSearchableTypes.
  • bank-tx.service.ts:
    • getBankTxsByName → uses the new constant (was inline spread incl. only BANK_TX_RETURN).
    • getUnassignedBankTx → new optional types param (default = BankTxUnassignedTypes), so the user-facing /transaction/unassigned endpoint is unaffected.
  • support.service.ts: IBAN/virtualIBAN branch passes BankTxComplianceSearchableTypes when calling getUnassignedBankTx.

Motivation

Already-returned or repeated deposits were invisible in compliance search, even though the sender's name/IBAN is still on the record. Example: bank_tx 156149 (MEEKERS MARCEL JOHANNES, returned 01.07.2025) — not findable by name until now.

Scope notes

  • BANK_TX_RETURN_CHARGEBACK intentionally not included (scope decision).
  • Kundenseitiger /transaction/unassigned bleibt unverändert (type default unchanged).

Test plan

  • Name search for MEEKERS MARCEL JOHANNES → bank_tx 156149 (type=BankTxReturn) must appear in bankTx list.
  • Name search that only matches a BankTxRepeat credit → must appear.
  • Name search on a Pending tx → still found (regression check).
  • IBAN search where the only matching tx is BankTxReturn/BankTxRepeat → must appear.
  • GET /transaction/unassigned (customer view) → still only GSheet/Unknown/Pending (no regression, no returns shown to customers).

@TaprootFreak TaprootFreak changed the title feat: include BankTxReturn in compliance name search feat: include BankTxReturn and BankTxRepeat in compliance search (name + IBAN) Apr 23, 2026
@TaprootFreak TaprootFreak merged commit a1d1ebb into develop Apr 23, 2026
7 checks passed
@TaprootFreak TaprootFreak deleted the feat/compliance-name-search-include-returns branch April 23, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants