feat: auto-derive recall user from bank tx#3617
Merged
TaprootFreak merged 1 commit intodevelopfrom Apr 23, 2026
Merged
Conversation
When POST /recall is called without an explicit userId, resolve the user via the BankTx.user getter (transaction → buyCrypto → buyCryptoChargeback → buyFiats). Load the top-level relations so the getter can resolve through the eager transaction.user chain. Backward compatible: callers passing userId explicitly keep their existing behavior.
TaprootFreak
force-pushed
the
feat/recall-auto-derive-user
branch
from
f0f9f61 to
96eb31e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bankTxIdbut no explicituserId, derive the user automatically from the bank-tx relation chain (transaction → buyCrypto → buyCryptoChargeback → buyFiats)BankTx.usergetter so it actually resolvesWhy
Lets the services frontend create recalls from contexts (user-data transactions tab) where no userId is available on the client side — the bank tx already knows its owning user via the existing getter, so deriving it server-side keeps the frontend simple.
Backward compatible: existing callers that pass
userIdexplicitly keep the same behavior.Test plan
{ bankTxId, sequence, reason, comment, fee }(no userId) → recall created,recall.usermatches the bankTx's owning useruserId→ behaves as beforecheckoutTxIdonly → unchanged