Skip to content

feat: include recall info in bank tx support responses#3618

Merged
TaprootFreak merged 2 commits intodevelopfrom
feat/recall-info-in-banktx-responses
Apr 23, 2026
Merged

feat: include recall info in bank tx support responses#3618
TaprootFreak merged 2 commits intodevelopfrom
feat/recall-info-in-banktx-responses

Conversation

@TaprootFreak
Copy link
Copy Markdown
Collaborator

Summary

  • Adds recall?: RecallSupportInfo to BankTxSupportInfo, so both the compliance search result and the user-data detail endpoint carry the recall (if any) directly on the bank tx
  • Lets the frontend render "Recall exists" state without an extra roundtrip
  • RecallService.findByBankTxIds batches the lookup for a whole response; SupportService builds a bankTxId → Recall map and hands it to toBankTxDto

Notes

  • RecallSupportInfo exposes id, created, sequence, reason, comment, fee — same fields as RecallListEntry minus the bankTx/checkoutTx/user refs (implicit from context)
  • No backend change to the recall creation flow
  • Requires the services PR (to be opened) to render the new field

Test plan

  • GET /support/userData/:id → bankTxs[i].recall present when a recall exists for that bank tx, absent otherwise
  • POST /support/userDataByKey (compliance search) → bankTx[i].recall present / absent accordingly

Compliance search and user-data detail responses now include an
optional recall object on each BankTxSupportInfo. The frontend can
render recall status inline without an additional roundtrip.

- RecallService.findByBankTxIds batches the lookup for all bankTxs of
  a response
- SupportService maps recalls by bankTx id and hands them to
  toBankTxDto
@TaprootFreak TaprootFreak merged commit 61a492c into develop Apr 23, 2026
7 checks passed
@TaprootFreak TaprootFreak deleted the feat/recall-info-in-banktx-responses branch April 23, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant