Skip to content

feat: realunit sell endpoints for bitbox#3635

Merged
xlamn merged 9 commits intodevelopfrom
feat/sell-for-bitbox
Apr 29, 2026
Merged

feat: realunit sell endpoints for bitbox#3635
xlamn merged 9 commits intodevelopfrom
feat/sell-for-bitbox

Conversation

@xlamn
Copy link
Copy Markdown
Collaborator

@xlamn xlamn commented Apr 28, 2026

Release Checklist

Pre-Release

  • Check migrations
    • No database related infos (sqldb-xxx)
    • Impact on GS (new/removed columns)
  • Check for linter errors (in PR)
  • Test basic user operations (on DFX services)
    • Login/logout
    • Buy/sell payment request
    • KYC page

Post-Release

  • Test basic user operations
  • Monitor application insights log

Comment thread src/subdomains/supporting/realunit/dto/realunit-sell.dto.ts
Comment thread src/subdomains/supporting/realunit/realunit.service.ts Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

❌ TypeScript: 1 errors

Copy link
Copy Markdown
Member

@davidleomay davidleomay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix TS errors

@xlamn xlamn marked this pull request as ready for review April 29, 2026 11:56
@xlamn xlamn requested a review from TaprootFreak as a code owner April 29, 2026 11:56
@xlamn xlamn merged commit 7437436 into develop Apr 29, 2026
7 checks passed
@xlamn xlamn deleted the feat/sell-for-bitbox branch April 29, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants