Add EUR bank fee differentiation (Olky 0.5%, Yapeal 2%)#3644
Merged
TaprootFreak merged 3 commits intodevelopfrom Apr 29, 2026
Merged
Add EUR bank fee differentiation (Olky 0.5%, Yapeal 2%)#3644TaprootFreak merged 3 commits intodevelopfrom
TaprootFreak merged 3 commits intodevelopfrom
Conversation
davidleomay
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bank Fee EUR 0.5%(fee id 141) hasbankId = NULLand applies to every EUR bank input regardless of bankOther EUR-denominated bank accounts (Bank Frick, Maerki Baumann, Revolut, Kaleido) had no or near-zero deposit volume in 2026 and lose the bank fee. New deposit channels via these banks must be re-evaluated explicitly before activation.
In-flight
buy_cryptorows whose fees have not been calculated yet (percentFee IS NULL) will pick up the new rates on the next preparation run.Test plan
bankId = 4and renamed label after deploymentbankId = 16,fiats = '2') is activebankId = 12,fiats = '2') is activebankPercentrate is 0.5%bankPercentrate is 2%bankPercentrate is 0.5%