Skip to content

Add EUR bank fee differentiation (Olky 0.5%, Yapeal 2%)#3644

Merged
TaprootFreak merged 3 commits intodevelopfrom
feat/yapeal-eur-bank-fee
Apr 29, 2026
Merged

Add EUR bank fee differentiation (Olky 0.5%, Yapeal 2%)#3644
TaprootFreak merged 3 commits intodevelopfrom
feat/yapeal-eur-bank-fee

Conversation

@TaprootFreak
Copy link
Copy Markdown
Collaborator

@TaprootFreak TaprootFreak commented Apr 29, 2026

Summary

  • Existing Bank Fee EUR 0.5% (fee id 141) has bankId = NULL and applies to every EUR bank input regardless of bank
  • Differentiate per bank for the three banks with active EUR deposit volume in 2026:
Fee ID Label Rate Bank
141 Bank Fee EUR Olky 0.5% (renamed) 0.5% Olkypay (id 4)
new Bank Fee EUR Yapeal 2% 2% Yapeal (id 16, matches both Yapeal IBANs by name)
new Bank Fee EUR Raiffeisen 0.5% 0.5% Raiffeisen (id 12)

Other EUR-denominated bank accounts (Bank Frick, Maerki Baumann, Revolut, Kaleido) had no or near-zero deposit volume in 2026 and lose the bank fee. New deposit channels via these banks must be re-evaluated explicitly before activation.

In-flight buy_crypto rows whose fees have not been calculated yet (percentFee IS NULL) will pick up the new rates on the next preparation run.

Test plan

  • Verify migration runs successfully on staging
  • Confirm fee 141 has bankId = 4 and renamed label after deployment
  • Confirm new Yapeal fee (rate 0.02, bankId = 16, fiats = '2') is active
  • Confirm new Raiffeisen fee (rate 0.005, bankId = 12, fiats = '2') is active
  • Quote a EUR buy via Olkypay account — bankPercent rate is 0.5%
  • Quote a EUR buy via Yapeal account — bankPercent rate is 2%
  • Quote a EUR buy via Raiffeisen account — bankPercent rate is 0.5%

@TaprootFreak TaprootFreak marked this pull request as draft April 29, 2026 10:36
@TaprootFreak TaprootFreak marked this pull request as ready for review April 29, 2026 10:38
@TaprootFreak TaprootFreak merged commit c29a25d into develop Apr 29, 2026
7 checks passed
@TaprootFreak TaprootFreak deleted the feat/yapeal-eur-bank-fee branch April 29, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants