perf: add indexes on all foreign key columns#3762
Merged
Merged
Conversation
davidleomay
force-pushed
the
perf/add-fk-indexes
branch
from
86d0810 to
5ddf9c9
Compare
PostgreSQL does not auto-create indexes on FK columns. Without them, every JOIN/WHERE on a FK does a sequential scan. This adds @Index() to all @manytoone relations (139 indexes).
davidleomay
force-pushed
the
perf/add-fk-indexes
branch
from
5ddf9c9 to
9278233
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Index()to all@ManyToOnerelations across 66 entity filesContext
PostgreSQL does not auto-create indexes on FK columns (unlike what's commonly assumed). Without them, every JOIN or WHERE on a FK column does a sequential full table scan. This is the primary cause of the performance degradation after the MSSQL → PostgreSQL migration, especially on support endpoints that load many relations per request.
Test plan