fix(lightning): add X-Forwarded-Proto header to LNBits API calls#3890
Merged
Conversation
LNBits requires HTTPS for LNURL endpoints and returns 426 when called over plain HTTP. On Azure, nginx added this header automatically. After migration to dfxdev, dfx-api calls LNBits directly without the header.
LNBits requires HTTPS for LNURL endpoints and returns 426 when called over plain HTTP. On Azure, nginx added this header automatically. After migration to dfxdev, dfx-api calls LNBits directly without the header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After DFX API migration from Azure to dfxdev, LNURL-pay links return HTTP 426 ("LNURLs need to be delivered over a publicly accessible
httpsdomain").On Azure, nginx terminated TLS in front of LNBits and added
X-Forwarded-Proto: httpsautomatically. On dfxdev, dfx-api calls LNBits directly over the Docker network without this header.Fix
Add
X-Forwarded-Proto: httpsheader to all LNBits API calls inhttpLnBitsConfig().Testing
GET https://dev.api.dfx.swiss/lnurlp/<linkId>— should return 200 with LNURL metadata instead of 426