Skip to content

fix(log): mark high totalBalanceChf FinancialDataLog entries of 2026-06-18 as invalid#3913

Closed
TaprootFreak wants to merge 1 commit into
developfrom
fix/invalidate-high-total-balance-logs-2026-06-18
Closed

fix(log): mark high totalBalanceChf FinancialDataLog entries of 2026-06-18 as invalid#3913
TaprootFreak wants to merge 1 commit into
developfrom
fix/invalidate-high-total-balance-logs-2026-06-18

Conversation

@TaprootFreak

Copy link
Copy Markdown
Collaborator

Recurrence of the transient accounting spike previously handled for 2026-06-15 (#3889), 2026-06-16 (#3892) and 2026-06-17 (#3903). The same root cause keeps surfacing: plusBalanceChf jumps ahead of the corresponding minusBalanceChf booking, inflating totalBalanceChf before it self-corrects once the liability is booked. Deltas at the elevated baseline stay within financeLogTotalBalanceChangeLimit, so entries are wrongly stamped valid=true.

This follow-up migration marks every FinancialDataLog entry of 2026-06-18 (UTC) with totalBalanceChf > 60 000 as valid=false, so monitoring dashboards and anomaly alerts reflect the period correctly.

  • Scope: created in [2026-06-18T00:00:00Z, 2026-06-19T00:00:00Z)
  • Threshold: totalBalanceChf > 60000 (raised from 50000 of the previous days to target this day's spike)
  • Affected rows: determined at apply time by the COUNT pre-check — to be confirmed via /gs/debug before merge (not yet verified)
  • COUNT pre-check makes up() a no-op on dev/staging
  • down() re-stamps valid=true for the same window/threshold (best-effort, one-shot)

Same shape as #3903 — data-only, no schema change.

⚠️ This is the 4th daily band-aid for the same unfixed root cause (booking-order race). Tracking a proper fix separately is overdue.

@github-actions

Copy link
Copy Markdown

⚠️ Unverified Commits (1)

The following commits are not signed/verified:

  • 5f186ec fix(log): mark high totalBalanceChf FinancialDataLog entries of 2026-06-18 as invalid (Cyrill Thommen)
How to sign commits
# SSH signing (recommended)
git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign true

# Re-sign last commit
git commit --amend -S --no-edit
git push --force-with-lease

@TaprootFreak TaprootFreak deleted the fix/invalidate-high-total-balance-logs-2026-06-18 branch June 18, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant