Skip to content

Feature/dev 667 buy crypto on ethereum#395

Merged
TonySemikin merged 94 commits into
developfrom
feature/DEV-667-buy-crypto-on-ethereum
Sep 9, 2022
Merged

Feature/dev 667 buy crypto on ethereum#395
TonySemikin merged 94 commits into
developfrom
feature/DEV-667-buy-crypto-on-ethereum

Conversation

@TonySemikin
Copy link
Copy Markdown
Contributor

@TonySemikin TonySemikin commented Sep 5, 2022 •
edited
Loading

Release Checklist

Pre-Release

  • Check migrations
    • No database related infos (sqldb-xxx)
    • Impact on GS (new/removed columns)
  • Check for linter errors (in PR)
  • Test basic user operations
    • Login/logout
    • Registration
    • Update user data
    • Create/delete payment routes

Post-Release

  • Test basic user operations
  • Monitor application insights log

@TonySemikin
[DEV-411] implemented generic payout module, happy path
86ea36b
@TonySemikin
[DEV-411] added payout module to payment parent module
913dfd0
@TonySemikin
[DEV-411] refactored buy-crypto to use new payout service
b1515c6
@TonySemikin
[DEV-411] finished refactoring and cleanup of buy-crypto
a973f94
@TonySemikin
[DEV-411] small improvements after first test run
3fff900
@TonySemikin
[DEV-411] removed unnecessary imports
dc2f7f3
@TonySemikin
[DEV-411] added node choice capability, depending on context
240ad67
@TonySemikin
[DEV-411] implemented corner cases protection and non-recoverable sce…
b42a5b6 
…nario
@TonySemikin
[DEV-411] created db migration
adc2012
@TonySemikin
[DEV-411] slightly improved log for new payout orders
0715511
@TonySemikin
[DEV-411] slightly improved log for token payout
748e33a
@TonySemikin
[DEV-411] returned INT wallet address config
96c4f96
@TonySemikin
Merge remote-tracking branch 'origin/develop' into feature/DEV-411-st…
1803f38 
…aking-reward-payout
@TonySemikin
Merge remote-tracking branch 'origin/develop' into feature/DEV-667-bu…
208643e 
…y-crypto-on-ethereum
@TonySemikin
[DEV-667] added ethereum configuration
bff8b4c
@TonySemikin
[DEV-667] regrouped blockchain layer, added ethereum module
2b7f30d
@TonySemikin
[DEV-667] scaffolded ethereum service and client
b40ed5a
@TonySemikin
[DEV-667] interim progress on payout module adaption
731dafc
@TonySemikin
[DEV-667] finished initial payout module adaption
d426cc2
@TonySemikin
[DEV-667] extracted logs service
d054d9c
@TonySemikin
[DEV-667] refactored dex module for ethereum
513799e
@TonySemikin
[DEV-667] first e2e ETH buy run
8ea3c8e
@TonySemikin
Merge remote-tracking branch 'origin/develop' into feature/DEV-667-bu…
8bae6d4 
…y-crypto-on-ethereum
@TonySemikin
[DEV-667] implemented remaining part of asset fetch and liquidity cal…
a08f62b 
…culation
@TonySemikin
[DEV-667] defined pricing interface
433b049
@TonySemikin
Merge remote-tracking branch 'origin/develop' into feature/DEV-667-bu…
f2f4b22 
…y-crypto-on-ethereum
@TonySemikin
[DEV-667] pricing paths configuration - WIP
1eb2cbe
@TonySemikin
[DEV-667] renamed path aliases - WIP
45cb65e
@TonySemikin
[DEV-667] added fixer service
2c07033
@TonySemikin
[DEV-667] fixed price requests from buy-crypto and staking
52953ad
davidleomay
davidleomay reviewed Sep 7, 2022
View reviewed changes
Comment thread src/app.module.ts Outdated
Comment thread src/shared/models/asset/asset.service.ts
Comment thread src/payment/models/dex/services/dex-defichain.service.ts Outdated
Comment thread src/payment/models/buy-crypto/entities/__mocks__/buy-crypto-batch.entity.mock.ts
Comment thread src/payment/models/dex/services/dex-evm.service.ts
Comment thread src/payment/models/pricing/utils/price-path.ts
Comment thread src/payment/models/pricing/utils/price-path.ts Outdated
Comment thread src/payment/models/pricing/utils/price-step.ts Outdated
Comment thread src/payment/models/pricing/utils/price-step.ts
Comment thread src/payment/models/pricing/utils/price-step.ts Outdated
@TonySemikin
[DEV-667] fixes after second test run findings
08f3940
@TonySemikin
[DEV-667] changed gsa limit to number
80581e6
@TonySemikin
[DEV-667] addressed PR comments
a65f5be
@TonySemikin
Merge remote-tracking branch 'origin/develop' into feature/DEV-667-bu…
a3518bf 
…y-crypto-on-ethereum
@TonySemikin
[DEV-667] fixed errors after develop merge
79ef34c
@TonySemikin
[DEV-667] implemented setting output reference to BTC for non-USD Fia…
97636f0 
…t input
@TonySemikin
[DEV-667] removed Fixer env and configuration
684498c
@TonySemikin
[DEV-667] adjusted setting output reference to BTC for non-USD Fiat i…
f5d9eab 
…nput
@TonySemikin
[DEV-667] added pricing path USDC -> USDT
70f536d
@TonySemikin
[DEV-667] removed redundant TODOs
3662891
@TonySemikin
[DEV-667] fixed ETH liquidity purchase mail
31f142b
@TonySemikin
[DEV-667] added blockchain column to migration
124ad24
@TonySemikin
[DEV-667] removed IS NOT NULL constraint from asset
2aebb8a
@TonySemikin
Merge remote-tracking branch 'origin/develop' into feature/DEV-667-bu…
eb80c9b 
…y-crypto-on-ethereum
@TonySemikin TonySemikin marked this pull request as ready for review September 9, 2022 08:12
@TonySemikin TonySemikin merged commit 42108b8 into develop Sep 9, 2022
@TonySemikin TonySemikin deleted the feature/DEV-667-buy-crypto-on-ethereum branch September 9, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidleomay davidleomay davidleomay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TonySemikin @davidleomay