[DEV-622] & [DEV-833] & [DEV-726] & [DEV-884] Buy crypto and notification features#456
Merged
Conversation
* [DEV-622] scaffolded strategies for bitcoin and erc-20 tokens * [DEV-622] restructured dex strategies * [DEV-622] added new strategies to facades * [DEV-622] adapted DexEvmService to token purchase * [DEV-622] restructured payout strategies * [DEV-622] added payout strategies placeholders * [DEV-622] private methds naming cleanup in dex module * [DEV-622] refactored payout service to group orders by strategies * [DEV-622] implemented dex strategies for bitcoin and eth tokens * [DEV-622] implemented prepare strategy for bitcoin * [DEV-622] added erc20 contract integration * [DEV-622] basic test swap for evm * [DEV-622] fixed abi import and denomination of erc20 tokens * [DEV-622] implemented new reference asset rules * [DEV-622] implemented btc to dfi pricing path * [DEV-622] refactored bitcoin payout strategy to use shared jellyfish functionality * [DEV-622] remove redundant method binding * [DEV-622] implemented reference assets rules for evm liquidity strategies * [DEV-622] fixed abi import path * [DEV-622] changed naming in dfi payout strategy * [DEV-622] several adjustments during testing * [DEV-622] fix payout completion check error * [DEV-622] made swap contract and token configurable * [DEV-622] fixed evm client construction * [DEV-622] extended env example file * [DEV-622] created migration * [DEV-622] implemented fallback to currency logic in pricing module * [DEV-622] Switched to ALTER COLUMN * [DEV-622] added env configuration * [DEV-622] addressed PR comments Co-authored-by: David May <david.leo.may@gmail.com>
* [DEV-726] created notification module structure * [DEV-726] added notification persistence and recurring rules * [DEV-726] added log to suppressed mails * [DEV-726] added notification module to app module * [DEV-726] first working error suppression * [DEV-726] slight improvement of request interface * [DEV-726] simplified mail request parameters * [DEV-726] refactored client calls to notification service * [DEV-726] fixed tests and removed former mail service * [DEV-726] improved correlation of incoming mail requests * [DEV-726] hard limited notification correlationId to 255 chars * [DEV-726] trade off improvement of mails naming * [DEV-726] added contollers for integration tests * [DEV-726] added migration * [DEV-726] after merge fixes * [DEV-726] small notification entity adjustment * [DEV-726] adjusted blockchain scan base urls for buy crypto confirmation * [DEV-726] after merge fixes * [DEV-726] addressed PR comments * [DEV-726] moved mail class to base directory * [DEV-726] after merge fixes
* [DEV-885] add amountIn Cols + migration * [DEV-885] add thunderclient
* [DEV-868] add custom col parameter * [DEV-868] Renaming + add comment * [DEV-868] remove unused code * [DEV-868] Refactoring
davidleomay
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Checklist
Pre-Release
Post-Release