Skip to content

[DEV-893], [DEV-864], [DEV-770], [DEV-292], [DEV-759] & [FIXES]#469

Merged
davidleomay merged 15 commits into
masterfrom
develop
Oct 24, 2022
Merged

[DEV-893], [DEV-864], [DEV-770], [DEV-292], [DEV-759] & [FIXES]#469
davidleomay merged 15 commits into
masterfrom
develop

Conversation

@Kolibri1990
Copy link
Copy Markdown
Collaborator

@Kolibri1990 Kolibri1990 commented Oct 24, 2022 •
edited by davidleomay
Loading

Release Checklist

Pre-Release

  • Check migrations
    • No database related infos (sqldb-xxx)
    • Impact on GS (new/removed columns)
  • Check for linter errors (in PR)
  • Test basic user operations
    • Login/logout
    • Registration
    • Update user data
    • Create/delete payment routes
  • Update PRD environment

Post-Release

  • Test basic user operations
  • Monitor application insights log

Yannick1712 and others added 10 commits October 20, 2022 09:44
@Yannick1712
[FIX] fix buyCrypto return mails
4d7d527
@Kolibri1990 @davidleomay
[DEV-864] Add part to completed requirement and also to fallback (#458)
d03a065 
* [DEV-864] Add part to completed requirement and also to fallback

* [DEV-864] Refactoring

* [DEV-864] Refactoring

* [DEV-864] Removed empty lines

Co-authored-by: David May <david.leo.may@gmail.com>
@davidleomay
Send payment mails to liq address (#464)
7d1eb8f
@davidleomay
[DEV-893] BTC Fee (#463)
ae984fc 
* [DEV-893] Using recommended fee and RBF for BTC send

* [DEV-893] Updated environment
@Yannick1712 @davidleomay
[DEV-770] Offshore kyc v2 (#455)
9ade950 
* [DEV-770] reload users with wallet

* [DEV-770] add wallet controller

* [DEV-770] add kycFailed webhook

* [DEV-770] KYC Light for LOCK users

* [DEV-770] apiKey Refactoring

* [DEV-770] add company method Get kycData

* [DEV-770] add Company SignIn challenge token

* Squashed commit of the following:

commit a5884ed
Author: TonySemikin <tony.semikin@gmail.com>
Date:   Fri Oct 14 11:43:56 2022 +0200

    [DEV-726] Improve BuyCrypto Monitoring (#421)

    * [DEV-726] created notification module structure

    * [DEV-726] added notification persistence and recurring rules

    * [DEV-726] added log to suppressed mails

    * [DEV-726] added notification module to app module

    * [DEV-726] first working error suppression

    * [DEV-726] slight improvement of request interface

    * [DEV-726] simplified mail request parameters

    * [DEV-726] refactored client calls to notification service

    * [DEV-726] fixed tests and removed former mail service

    * [DEV-726] improved correlation of incoming mail requests

    * [DEV-726] hard limited notification correlationId to 255 chars

    * [DEV-726] trade off improvement of mails naming

    * [DEV-726] added contollers for integration tests

    * [DEV-726] added migration

    * [DEV-726] after merge fixes

    * [DEV-726] small notification entity adjustment

    * [DEV-726] adjusted blockchain scan base urls for buy crypto confirmation

    * [DEV-726] after merge fixes

    * [DEV-726] addressed PR comments

    * [DEV-726] moved mail class to base directory

    * [DEV-726] after merge fixes

commit 40988a7
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Fri Oct 14 11:36:33 2022 +0200

    [DEV-884] add Pending bankTx type

commit 2b176ef
Author: TonySemikin <tony.semikin@gmail.com>
Date:   Fri Oct 14 10:20:31 2022 +0200

    [DEV-622], [DEV-833] buy crypto btc, eth tokens, bsc tokens (#446)

    * [DEV-622] scaffolded strategies for bitcoin and erc-20 tokens

    * [DEV-622] restructured dex strategies

    * [DEV-622] added new strategies to facades

    * [DEV-622] adapted DexEvmService to token purchase

    * [DEV-622] restructured payout strategies

    * [DEV-622] added payout strategies placeholders

    * [DEV-622] private methds naming cleanup in dex module

    * [DEV-622] refactored payout service to group orders by strategies

    * [DEV-622] implemented dex strategies for bitcoin and eth tokens

    * [DEV-622] implemented prepare strategy for bitcoin

    * [DEV-622] added erc20 contract integration

    * [DEV-622] basic test swap for evm

    * [DEV-622] fixed abi import and denomination of erc20 tokens

    * [DEV-622] implemented new reference asset rules

    * [DEV-622] implemented btc to dfi pricing path

    * [DEV-622] refactored bitcoin payout strategy to use shared jellyfish functionality

    * [DEV-622] remove redundant method binding

    * [DEV-622] implemented reference assets rules for evm liquidity strategies

    * [DEV-622] fixed abi import path

    * [DEV-622] changed naming in dfi payout strategy

    * [DEV-622] several adjustments during testing

    * [DEV-622] fix payout completion check error

    * [DEV-622] made swap contract and token configurable

    * [DEV-622] fixed evm client construction

    * [DEV-622] extended env example file

    * [DEV-622] created migration

    * [DEV-622] implemented fallback to currency logic in pricing module

    * [DEV-622] Switched to ALTER COLUMN

    * [DEV-622] added env configuration

    * [DEV-622] addressed PR comments

    Co-authored-by: David May <david.leo.may@gmail.com>

commit 2da67ba
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Wed Oct 12 12:17:34 2022 +0200

    [DEV-862] bankTxReturn update method (#450)

    * [DEV-862] add update method

    * [DEV-862] Refactoring 1

    * [DEV-862] renaming

commit aa675a6
Author: David May <85513542+davidleomay@users.noreply.github.com>
Date:   Wed Oct 12 11:07:22 2022 +0200

    Improved logging for BuyCrypto and Spider errors (#451)

commit e6f3d48
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Tue Oct 11 17:25:24 2022 +0200

    [FIX] error handling

commit 1c54057
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Tue Oct 11 17:02:04 2022 +0200

    [FIX] kyc-webhook wallet fix

commit 234ee8b
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Tue Oct 11 15:58:16 2022 +0200

    [DEV-860] add BankTxReturn Cols + migration (#448)

    * [DEV-860] add BankTxReturn Cols + migration

    * [DEV-860] Refactoring

    * [DEV-860] Refactoring 2

commit 13273b9
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Tue Oct 11 15:48:09 2022 +0200

    [DEV-847] add buyCrypto Pending Mails (#447)

    * [DEV-847] add buyCrypto Pending Mails

    * [DEV-847] Refactoring 1

    * [DEV-847] Refactoring 2

    * [DEV-847] Refactoring 3

    * [DEV-847] remove unused code

    Co-authored-by: David May <david.leo.may@gmail.com>

commit 1ef4121
Author: David May <david.leo.may@gmail.com>
Date:   Mon Oct 10 15:33:12 2022 +0200

    [DEV-769] Added API key to env

commit 5f420d8
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Mon Oct 10 13:15:39 2022 +0200

    [FIX] fix unit test

commit 3728369
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Mon Oct 10 12:58:58 2022 +0200

    [DEV-801] & [DEV-802]: min Deposit (#443)

    * [DEV-801] & [DEV-802]: min Deposit

    * [DEV-801]&[DEV-802] change config

    * [DEV-801] Refactoring

    * [DEV-801] move getMinDeposit

commit 5c79d35
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Sat Oct 8 13:54:54 2022 +0200

    [FIX] fix unit test

commit 3f38798
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Sat Oct 8 13:06:46 2022 +0200

    [FIX] Mail Update

commit 5c2a881
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Sat Oct 8 11:25:30 2022 +0200

    [FIX] fix

commit 8f7f054
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Sat Oct 8 11:19:47 2022 +0200

    [FIX] remove seed

commit 71caf5c
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Sat Oct 8 10:08:23 2022 +0200

    [FIX] Refactoring

commit 598a242
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Thu Oct 6 19:53:30 2022 +0200

    [DEV-827] change kyc mail text (#444)

    * [FIX] fix payback Mail Text

    * [DEV-827] kyc mail changed text part

commit f5bb374
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Thu Oct 6 17:17:14 2022 +0200

    [FIX] fix linter error

commit 5255772
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Thu Oct 6 17:10:58 2022 +0200

    [DEV-829] bank table (#440)

    * [DEV-829] add bank + migration

    * [DEV-829] move bankSelector, refactoring

    * [DEV-829] Refactoring

    * [DEV-829] Refactoring 2

    * [DEV-829] add unit tests + Refactoring

    * [DEV-829] remove ibans in config

    * [DEV-829] Refactoring unit tests

commit a78d84c
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Thu Oct 6 16:41:11 2022 +0200

    [DEV-813] buyCrypto return Mails (#442)

    * [DEV-813] add buyCrypto return Mails + add amlReasons

    * [DEV-813] add amlReason Mail texts

    * [DEV-813] Refactoring

    * [DEV-851] add buyCryptoReturn Mail Translation

commit 6c0aa85
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Wed Oct 5 22:47:14 2022 +0200

    [DEV-849] fix dto check

commit 1b117a8
Author: Yannick1712 <nickbusch1998@gmail.com>
Date:   Wed Oct 5 17:34:34 2022 +0200

    [DEV-849] rename wallet description col + change kycDataTransferDto

commit d301bc3
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Wed Oct 5 15:16:00 2022 +0200

    [DEV-839] add bankTxRepeat Tabel + migration (#441)

commit 5c45c47
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Wed Oct 5 09:42:04 2022 +0200

    [DEV-832] add bankTxReturn + migration (#439)

    * [DEV-832] add bankTxReturn + migration

    * [DEV-832] Refactoring

commit c13cce8
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Mon Oct 3 11:47:08 2022 +0200

    [DEV-36]&[DEV-174] remove crypto sell + crypto buy (#422)

    * [DEV-36] Remove cryptoSell

    * [DEV-174] Remove CryptoBuy + Refactoring

    * [DEV-36] & [DEV-174] remove thunderClient/Collection entries

commit 64403f5
Author: Yannick1712 <52333989+Yannick1712@users.noreply.github.com>
Date:   Sat Oct 1 16:02:15 2022 +0200

    [DEV-831] new bankTx types (#438)

    Co-authored-by: Kolibri1990 <66674482+Kolibri1990@users.noreply.github.com>
    Co-authored-by: David May <85513542+davidleomay@users.noreply.github.com>
    Co-authored-by: David May <david.leo.may@gmail.com>
    Co-authored-by: TonySemikin <tony.semikin@gmail.com>

* [DEV-770] Refactoring 1

* [DEV-770] add KycWebhookStatus Rejected

* [DEV-770] Refactoring 2

* [DEV-770] disable kyc mails for externalUser

* [DEV-770] Refactoring 3

* [DEV-770] move challenge null check

* [DEV-770] Refactoring 4

* [DEV-770] Refactoring 5

* [DEV-770] change merge check

* [DEV-770] Refactoring 6

Co-authored-by: David May <david.leo.may@gmail.com>
@Yannick1712
[FIX] fix unit tests
d9e09b5
@Kolibri1990
[DEV-808] Add contribution '0' to business account (#465)
a064324
@davidleomay
Switched to REF node for staking swaps
2a7995d
@Yannick1712
[DEV-292] remove unused user fields + migration (#462)
3833370 
* [DEV-292] remove unused user fields + migration

* [DEV-292] fix unit tests
@Kolibri1990
[DEV-759] Round statistic values to 2 decimals (#466)
88ed86f 
* [DEV-759] Round statistic values to 2 decimals

* [DEV-759] Change decimal value  to config default value
@Yannick1712
[DEV-902] add buyFiat Pending Mail (#468)
567e924 
* [DEV-902] add buyFiat Pending Mail

* [DEV-902] Refactoring
@Yannick1712
[DEV-946] add amlReason (#473)
92d1d02 
* [DEV-946] add amlReason

* [DEV-946] add translation
@Yannick1712
[DEV-903] pending mail olky (#471)
ed4ad2c 
* [DEV-903] add olky Pending Mail

* [DEV-903] add translations
@Yannick1712
[DEV-904] add support Mail (#470)
65bc7a9 
* [DEV-904] add support Mail

* [DEV_904] add mail To Link
@davidleomay davidleomay merged commit eed7caa into master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yannick1712 Yannick1712 Yannick1712 approved these changes

@davidleomay davidleomay davidleomay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kolibri1990 @Yannick1712 @davidleomay