chore: rename Go module path to github.com/DFXswiss/bitbox_flutter#19
Merged
Conversation
The Go module under /go/ was still on the old fork path github.com/konstantinullrich/bitbox_flutter. Now that the repo lives under DFXswiss, the module path should match — same alignment we did on bitbox-testkit. Single import in go/api/api.go updated alongside the module statement. `go mod tidy` cleaned out indirect deps that were never reached from this module (gnark-crypto, c-kzg, verkle, blst, etc.). Verified: `go vet ./...` clean, `go test -race -timeout 60s ./...` passes both api and u2fhid packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go/go.modwas still ongithub.com/konstantinullrich/bitbox_flutter— the original fork path. Now that the repo lives under DFXswiss, the module path should match. Same alignment we did on bitbox-testkit (commit a573ab0).Changes
go/go.mod: module declaration →github.com/DFXswiss/bitbox_flutter.go/api/api.go: the one internal import that referenced the old path.go/go.sum:go mod tidyran a long-deferred cleanup (the previous bitbox02-api-go bump never tidied). Removes a fistful of transitive deps no longer in the tree (gnark-crypto, c-kzg, verkle, blst, gopsutil, fastssz, etc.) and pulls in the one new transitive (karalabe/hid, USB transport now reached via the newer bitbox02-api-go).Why the bindings keep working
The generated Kotlin/Swift bindings reference the Go binding by the last path component (
api, e.g. Kotlin'simport api.Api), not by the full module path. Renaming…/konstantinullrich/bitbox_flutter→…/DFXswiss/bitbox_fluttertherefore does not break:android/src/main/kotlin/com/cakewallet/bitbox_flutter/*.ktandroid/libs/api.aar(Java package staysapi)ios/Api.xcframework/(ObjC class names stayApi*)Verified by grep: no Kotlin/Swift/Dart consumer references the full Go module path.
Generated artifacts left alone
Four files in
ios/Api.xcframework/**/Api.{h,objc.h}and theandroid/libs/api-sources.jarstill contain the old module path in comments:These are auto-generated by
gomobile bindand explicitly markedFile is generated by gomobile bind. Do not edit.. Hand-patching the comments would (a) violate that contract and (b) drift back the moment anyone runsgomobile bindagain. They will refresh naturally on the next release build (run_build_tool_android.sh/ iOS xcframework rebuild). Cosmetic-only — no runtime behavior depends on them.Local validation
go vet ./...go test -race -timeout 60s ./...grep -rn konstantinullrich go/grep -rn konstantinullrich android/src ios/Classes lib test exampleStacking
Independent of #18 (CI improvements). After #18 lands, this PR's CI will pick up the new Go test job automatically.