Support uid parameter for getTransactionInvoice #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change invoice URL function to accept number | string - Update getTransactionInvoice signature to accept number | string This allows fetching invoices using transaction uid (for pending transactions that don't have a numeric id yet).
TaprootFreak
added a commit
to DFXswiss/services
that referenced
this pull request
Jan 22, 2026
- Change invoice button to use tx.uid instead of tx.id - Remove hidden condition (button always visible now) - Update isInvoiceLoading state type to string This enables invoice download for pending transactions that don't have a numeric id yet. Note: Requires @dfx.swiss/react package update (DFXswiss/packages#124)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TransactionUrl.invoiceto acceptnumber | stringgetTransactionInvoicesignature to acceptnumber | stringWhy
Pending transactions (e.g., "Warten auf Zahlung") don't have a numeric
id, only auid. This change allows fetching invoices using the uid.Related PRs
Test plan