Fix BitBox ETH support for Multi editions#1033
Merged
TaprootFreak merged 1 commit intodevelopfrom Mar 30, 2026
Merged
Conversation
bitbox-api v0.2.1 has a WASM binding bug where ethSupported() calls pairedbitbox_cardanoSupported instead of pairedbitbox_ethSupported, returning false for BitBox02 Multi editions that do support ETH. Instead of pre-checking ethSupported(), attempt ETH address fetch directly and only fall back to BTC if the device actually rejects the request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ethSupported()WASM binding bug in bitbox-api v0.2.1 that returnsfalsefor BitBox02 Multi editionsethSupported(), attempt ETH address fetch directly and only fall back to BTC if the device rejects the requestethSupported()returnstruebut ETH still fails, the real error is propagated (not swallowed)Root cause
bitbox-apiv0.2.1ethSupported()internally callswasm.pairedbitbox_cardanoSupportedinstead ofpairedbitbox_ethSupported. This bug persists through v0.12.0. Library update is blocked by ESM/Webpack incompatibility (see #1032).Test plan
0x...)Relates to #1032