Merged
Conversation
davidleomay
reviewed
Mar 31, 2023
davidleomay
approved these changes
Apr 3, 2023
davidleomay
added a commit
that referenced
this pull request
Jul 9, 2024
TaprootFreak
added a commit
that referenced
this pull request
Apr 9, 2026
- Extract XML builder to src/util/camt053-builder.ts (#6) - Add IBAN validation via Validations.Iban for both IBAN fields (#2) - Escape bookingDate/valueDate/currency in XML output (#3) - Add NaN guard for parseFloat on amount (#5) - Use crypto.randomUUID() for AcctSvcrRef (#8) - Change button label from "Next" to "Upload" (#10)
TaprootFreak
added a commit
that referenced
this pull request
Apr 10, 2026
* feat: add manual bank transaction entry page at /sepa/manuell Add a form-based alternative to XML file upload for creating bank transactions. The form generates a CAMT.053 XML and submits it via the existing POST /bankTx endpoint. Admin-only access enforced via useAdminGuard() on frontend and RoleGuard(BANKING_BOT) on API. * refactor: improve XML builder readability and fix escapeXml crash - Fix escapeXml crash on undefined values for optional address fields - Extract escapeXml, buildPartyXml, buildCamt053Xml outside component - Break long inline XML strings into readable multi-line structure - Only emit address XML tags for fields that have values * fix: remove unused iban parameter from buildPartyXml * fix: align address fields with repo pattern and make bank data configurable - Rename buildingNumber→houseNumber, postalCode→zip to match codebase - Use StyledHorizontalStack for Street+Nr and ZIP+City rows - Replace plain Country input with StyledSearchDropdown<Country> - Add autocomplete attributes matching existing screens - Replace hardcoded ACCOUNT_IBAN/OWNER/BANK with form fields - Fix amount formatting to 2 decimal places - Remove unused async from onSubmit * fix: remove type=submit to prevent double form submission * fix: address all review comments - Extract XML builder to src/util/camt053-builder.ts (#6) - Add IBAN validation via Validations.Iban for both IBAN fields (#2) - Escape bookingDate/valueDate/currency in XML output (#3) - Add NaN guard for parseFloat on amount (#5) - Use crypto.randomUUID() for AcctSvcrRef (#8) - Change button label from "Next" to "Upload" (#10) * Fix navigation path for manual entry button * Fix typo in route path from 'manuell' to 'manual' --------- Co-authored-by: David May <85513542+davidleomay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.