Feature/safe withdraw send #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename findBalanceString to findCustodyBalanceString for clarity - Add onSourceAssetChange callback to reset fields when source asset changes - Filter swap target assets to exclude selected source asset - Fix address overflow in send interface with break-all - Improve receive interface validation logic - Adjust BankAccountSelector positioning and modal margins - Fix payment info rendering when targetAsset is undefined
- Fiat withdraw: filter assets to only dEURO/ZCHF, auto-map target currency - Fiat withdraw: remove 'You get about' section, update confirm button text - Crypto withdraw: change 'Send' terminology to 'Withdraw' in UI - Crypto withdraw: filter addresses to Ethereum only, remove 'Switch address' option - Add confirmButtonLabel prop to OrderInterface and PaymentInfo components
Danswar
reviewed
Dec 9, 2025
Danswar
requested changes
Dec 9, 2025
Collaborator
Danswar
left a comment
Danswar
left a comment
There was a problem hiding this comment.
The layout is broken, there seems to be a button behind the selector?
Collaborator
|
I can't select ZCHF here 
|
Danswar
reviewed
Dec 9, 2025
Collaborator
|
Please fix the alignment in this table 
|
Collaborator
Author
|
ZCHF is not available because the test account only has dEURO, USDT, and ETH balance.
dEURO → Is in WITHDRAW_PAIRS and has balance (1345.2) You can only withdraw what you have in your Safe. |
Danswar
reviewed
Dec 11, 2025
Danswar
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves SAFE withdraw interface for fiat and crypto operations.
Changes
Fiat Withdraw
Crypto Withdraw