fix: normalize IBAN search key by removing spaces #916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix IBAN search in Compliance page not finding results when IBAN contains spaces.
Problem
When searching for an IBAN with spaces (e.g.,
DE81 3701 9000 1011 3760 35), the search returned "No user or bankTx found" because the API expects IBANs without spaces.Solution
Use
ibantoolslibrary to validate and normalize IBAN input:electronicFormatIBAN()removes spaces and converts to uppercaseisValidIBAN()verifies the IBAN checksumOnly valid IBANs are transformed. All other search terms (names, emails, blockchain addresses, etc.) remain unchanged.
Test plan
DE81 3701 9000 1011 3760 35→ normalizedDE81370190001011376035→ unchangedMax Mustermann→ unchangedDE12 Technologies GmbH→ unchanged (invalid checksum)test@example.com→ unchangedbc1q...,0x...→ unchanged