[WIP] Optimize code for new OpenAI poetic brain integration#4
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot stopped work on behalf of
DHCross due to an error
December 24, 2025 15:48
DHCross
added a commit
that referenced
this pull request
Mar 2, 2026
…ge clarity HIGH priority: - #6 symbolicWeather: soft-fail instead of re-throwing AuthorityViolationError - #7 TTS: add 10s AbortController timeout to ElevenLabs fetch (504 on timeout) - #9 injectProtocols: wrap in try/catch, continue without corpus on failure MEDIUM priority: - #2 LLM auth: normalize 401/403 to user-friendly message - #3 LLM timeout: add one retry in generateReplyWithRetry - #4 Empty LLM response: distinguish content_filter from true empty - #5 AuthorityViolation outer catch: hide internal module names LOW priority: - #1 Missing LLM key 503: clearer operator message - #8 useOracleChat: map 413 to user-friendly 'message too long' text - #10 Remove void-cast needsConcreteRetry/needsProtocolRepair calls
DHCross
added a commit
that referenced
this pull request
Apr 28, 2026
…structure failures (invariant #4) When the stream finalize block catches an error but a hardened reply or accumulated buffer is still salvageable, the failure is post-process decoration (hash computation, metadata stamping, etc.) — not a true infrastructure outage. Stop stapling a SYSTEM/REASON/ACTION banner to narrated prose in that case. - Salvageable path: emit the prose alone with systemNotice='POSTPROCESS_DEGRADED', isFallback=true, generated=true, llmFailureReason='stream_finalize_postprocess_degraded'. No SYSTEM banner appears in the visible reply. - Unsalvageable path: keep the existing buildStreamFinalizeFailedMessage SYSTEM string with systemNotice='FINALIZE_FAILED'. The user must see infrastructure failure when there is no narrated content to surface. Adds two behavioral assertions in recoveryMessages.test.ts: - The helper still emits a SYSTEM/REASON/ACTION banner on the no-salvage path (the genuine infrastructure-failure contract). - The helper prefers finalizedReply over accumulatedReply in the appended-banner composite. Doctrine boundary preserved: SYSTEM/REASON/ACTION schema lives only in recoveryMessages.ts and is reached only when nothing salvageable exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.