Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the field-report experience by (1) delaying the Alignment Corridor’s “taking longer than usual” timeout messaging to better tolerate legitimately long symbolic-moment computations, and (2) making Moon-sign extraction more resilient by falling back to additional payload shapes.
Changes:
- Increased the corridor soft-timeout threshold from 25s to 45s before switching to “timeout” UI copy.
- Expanded
extractMoonSignfallback logic to also checkcandidateRoot.moon.signandcandidateRoot.moon.moon_signwhen thelunar_phaserow lacks sign fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vessel/src/components/AlignmentCorridor.tsx | Extends corridor timeout threshold to reduce premature timeout UI. |
| vessel/src/lib/raven/lunarPhaseContext.ts | Adds Moon-sign extraction fallback from moon payload roots. |
Comment on lines
+67
to
70
| const planetSign = asString(moonData?.sign) | ||
| || asString(standaloneMoon?.sign) | ||
| || asString(standaloneMoon?.moon_sign); | ||
| if (planetSign) return normalizePhaseLabel(planetSign); |
Comment on lines
+66
to
+69
| const standaloneMoon = asRecord(candidateRoot?.moon); | ||
| const planetSign = asString(moonData?.sign) | ||
| || asString(standaloneMoon?.sign) | ||
| || asString(standaloneMoon?.moon_sign); |
DHCross
deleted the
codex/fix-glyph-animations-in-alignment-corridors-n14vkt
branch
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
25000ms to45000ms so the UI waits longer before showing the timeout copy (vessel/src/components/AlignmentCorridor.tsx).extractMoonSignto also inspectmoon.signandmoon.moon_signon candidate payload roots when thelunar_phaserow lacks sign fields (vessel/src/lib/raven/lunarPhaseContext.ts).vessel/src/components/AlignmentCorridor.tsx,vessel/src/lib/raven/lunarPhaseContext.ts.Testing
cd vessel && npm run typecheck, which completed successfully.cd vessel && npm test -- --run src/lib/raven/__tests__/lunarPhaseContext.test.ts src/components/__tests__/AlignmentCorridor.session.test.tsxwas attempted but the runner expanded into the full smoke suite where unrelated pre-existing failures surfaced; the targeted changes did not introduce type errors and the lunar-phase extraction and corridor timeout logic were exercised during the run.work, commit12aab21d11de630b128632da23d78e9a1f4407de, changed files committed locally, pushed:No, preview deployment:No.Codex Task