[dev] added note about fixed cardHeight as the recommended way to use…#77
Merged
[dev] added note about fixed cardHeight as the recommended way to use…#77
Conversation
… lazy render with column scroll
mafanya23
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… lazy render with column scroll
a comment WHY:
currently, there is a requirement to use cardHeight with lazy rendering and default layouts. for column scroll layouts, there is logic that counts average heights and predicts sizes and scroll position to show cards during scroll and dnd.
the current logic is not infallible, unfortunately. we received a bug report and there is a sufficiently good fix at the moment, but the overall sentiment is "the code is complex and still not infallible, it will fail in other circumstances like custom templates etc, it's probably better to remove this logic for good and fix the height of cards to make it reliable, predictable and better maintaineable".
however, we can't just remove it for the sake of the users who already rely on variable height and lazy rendering in column layouts.
therefore we decided to mark the fixed height as the recommended way to use lazy + column scroll and the logic that predicts heights based on current variable heights of cards as somewhat experimental and not entirely reliable.