Infra lifecycle management#69
Merged
victoragnez merged 6 commits intodevelopfrom Nov 16, 2018
Merged
Conversation
victoragnez
requested changes
Nov 16, 2018
| * Hello world! | ||
| * | ||
| */ | ||
| public class App { |
| */ | ||
| public interface ILifecycleManagement { | ||
|
|
||
| public Object getInvoker( AbsoluteObjectReference aor); |
Member
There was a problem hiding this comment.
Shouldn't it return a Invoker instead of Object?
| public interface ILifecycleManagement { | ||
|
|
||
| public Object getInvoker( AbsoluteObjectReference aor); | ||
| public void invocationDone( Object obj); |
Member
There was a problem hiding this comment.
Change parameters to AOR and Invoker
| @@ -0,0 +1,6 @@ | |||
| package br.ufrn.dimap.middleware.infrastructure.lifecycleManagement.modelo; | |||
|
|
|||
| public interface IStaticRegistry | |||
Member
There was a problem hiding this comment.
Change interface name to StaticRegistry, following the pattern used by the others classes and interfaces
| * @version 1.0 | ||
| * @see LifecycleManagement Interface | ||
| */ | ||
| public interface ILifecycleManagement { |
Member
There was a problem hiding this comment.
Change interface name to LifecycleManagement, following the pattern used by the others classes and interfaces
|
|
||
| import br.ufrn.dimap.middleware.infrastructure.lifecycleManagement.modelo.IStaticRegistry; | ||
|
|
||
| public class StaticRegistry implements IStaticRegistry |
Member
There was a problem hiding this comment.
Change interface name to StaticRegistryImpl, following the pattern used by the others classes and interfaces
| * @version 1.0 | ||
| * @see Lifecycle Management | ||
| */ | ||
| public class LifecycleManagement implements ILifecycleManagement { |
Member
There was a problem hiding this comment.
Change interface name to LifecycleManagementImpl, following the pattern used by the others classes and interfaces
victoragnez
approved these changes
Nov 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.