Merged
Conversation
Allyson-English
approved these changes
Mar 19, 2025
Member
Author
|
Okay I changed |
elffjs
commented
Mar 21, 2025
| unit: A | ||
| description: Current AC charging current (rms) at inlet. Negative if returning energy to grid. Used when per-phase numbers are unavailable. | ||
|
|
||
| Vehicle.Powertrain.TractionBattery.Charging.ChargeVoltage.UnknownType: |
There was a problem hiding this comment.
I like unkownType because no one is going to use this without looking at the description.
KevinJoiner
approved these changes
Mar 21, 2025
| datatype: float | ||
| type: sensor | ||
| unit: A | ||
| description: Current AC charging current (rms) at inlet. Negative if returning energy to grid. Used when per-phase numbers are unavailable. |
Member
Author
There was a problem hiding this comment.
The thing is they use it without comment in the main file.
Member
Author
There was a problem hiding this comment.
I think you either think about it (hey the current is variable so what are you saying) or it's just a number to you, to be compared with other numbers.
I've never heard of something doing any other summary statistic, to be honest with you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulling two signals from #9. These seem like the other important charging measurements. We can negotiate the rest tomorrow.
We are searching for target VSS signals for two Tesla signals:
ChargeAmps: This is indeed in amps. The description is "AC charger's sensed input line current". True to that description, the signal only shows up during AC charging. VSS hasCharging.ChargeCurrent.Phase{1,2,3}. Most home chargers are one-phase, but in Europe there are some three-phase. I'm trying to find one in order to confirm that this is the average current across the three phases (you expect them to roughly be the same) in those cases.ChargerVoltage. This is in volts. The description is "RMS value of AC charger's sensed input voltage". This turns out to be misleading and in fact we're sent this value during DC charging as well. VSS hasCharging.ChargeVoltage.Phase{1,2,3}for AC andCharging.ChargeVoltage.DCfor DC. We need something universal.I've picked "Actual" out of a hat—"Current" would be great except it's an overloaded word in this file. "Measured" would also be fine.I went withUnknownTypeto be explicit. I could not bring myself to doUnknownCurrentType.