Skip to content

feat: add events stream and refactor stream organization#44

Merged
KevinJoiner merged 6 commits intomainfrom
ex-3771-add-events-ingest-in-dps
Jul 22, 2025
Merged

feat: add events stream and refactor stream organization#44
KevinJoiner merged 6 commits intomainfrom
ex-3771-add-events-ingest-in-dps

Conversation

@KevinJoiner
Copy link
Copy Markdown
Contributor

  • Add new events stream processing pipeline with Kafka input and ClickHouse output
  • Reorganize stream files into dedicated streams/ directory for better organization
  • Update database migration processors with new naming conventions
  • Add new eventstoslice processor for converting events to slice format
  • Update signalstoslice processor with new naming convention
  • Refactor Helm chart templates to dynamically mount stream files
  • Update environment variables and configuration for unified database naming
  • Update Makefile linting paths to reflect new stream organization
  • Add new Kafka topic configuration for device events

- Add new events stream processing pipeline with Kafka input and ClickHouse output
- Reorganize stream files into dedicated streams/ directory for better organization
- Update database migration processors with new naming conventions
- Add new eventstoslice processor for converting events to slice format
- Update signalstoslice processor with new naming convention
- Refactor Helm chart templates to dynamically mount stream files
- Update environment variables and configuration for unified database naming
- Update Makefile linting paths to reflect new stream organization
- Add new Kafka topic configuration for device events
@linear
Copy link
Copy Markdown

linear Bot commented Jul 18, 2025

format: json
static_fields:
'appname': zone.dimo.dps
'app': zone.dimo.dps
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes this consistent with our other services.

@KevinJoiner KevinJoiner requested a review from Copilot July 22, 2025 17:02
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new events stream processing pipeline with Kafka input and ClickHouse output while reorganizing the codebase for better maintainability. The changes introduce a dedicated events processor alongside existing signal processing and unify the database naming conventions.

  • Add new events stream processing pipeline with Kafka input and ClickHouse output
  • Reorganize stream files into dedicated streams/ directory structure
  • Update database migration processors and environment variables with unified naming conventions

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
main.go Import new eventstoslice processor package
internal/processors/signalstoslice/signaltoslice.go Fix package name and update processor registration name
internal/processors/eventstoslice/eventstoslice.go Add new processor for converting events to slice format
internal/processors/dbmigration/processors.go Update processor names with new naming conventions
go.mod Update dependencies to newer versions
charts/dps/values.yaml Add events topic configuration and unify database environment variables
charts/dps/templates/deployment.yaml Dynamically mount stream files from streams directory
charts/dps/templates/configmap.yaml Include streams directory in config map
charts/dps/files/streams/*.yaml Update processor names and database references to use new conventions
Makefile Update linting paths to reflect new stream organization
Comments suppressed due to low confidence (1)

internal/processors/signalstoslice/signaltoslice.go:1

  • The package name 'signaltoslice' should be 'signalstoslice' to match the directory name and be consistent with the plural naming convention used in 'eventstoslice'.
package signaltoslice

Comment thread internal/processors/eventstoslice/eventstoslice.go Outdated
Comment thread Makefile Outdated
@KevinJoiner KevinJoiner force-pushed the ex-3771-add-events-ingest-in-dps branch from 1c9b153 to 3d94c3d Compare July 22, 2025 17:47
@KevinJoiner KevinJoiner merged commit ca3d908 into main Jul 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants