feat: add events stream and refactor stream organization#44
Merged
KevinJoiner merged 6 commits intomainfrom Jul 22, 2025
Merged
feat: add events stream and refactor stream organization#44KevinJoiner merged 6 commits intomainfrom
KevinJoiner merged 6 commits intomainfrom
Conversation
Contributor
KevinJoiner
commented
Jul 18, 2025
- Add new events stream processing pipeline with Kafka input and ClickHouse output
- Reorganize stream files into dedicated streams/ directory for better organization
- Update database migration processors with new naming conventions
- Add new eventstoslice processor for converting events to slice format
- Update signalstoslice processor with new naming convention
- Refactor Helm chart templates to dynamically mount stream files
- Update environment variables and configuration for unified database naming
- Update Makefile linting paths to reflect new stream organization
- Add new Kafka topic configuration for device events
- Add new events stream processing pipeline with Kafka input and ClickHouse output - Reorganize stream files into dedicated streams/ directory for better organization - Update database migration processors with new naming conventions - Add new eventstoslice processor for converting events to slice format - Update signalstoslice processor with new naming convention - Refactor Helm chart templates to dynamically mount stream files - Update environment variables and configuration for unified database naming - Update Makefile linting paths to reflect new stream organization - Add new Kafka topic configuration for device events
KevinJoiner
commented
Jul 22, 2025
| format: json | ||
| static_fields: | ||
| 'appname': zone.dimo.dps | ||
| 'app': zone.dimo.dps |
Contributor
Author
There was a problem hiding this comment.
makes this consistent with our other services.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new events stream processing pipeline with Kafka input and ClickHouse output while reorganizing the codebase for better maintainability. The changes introduce a dedicated events processor alongside existing signal processing and unify the database naming conventions.
- Add new events stream processing pipeline with Kafka input and ClickHouse output
- Reorganize stream files into dedicated streams/ directory structure
- Update database migration processors and environment variables with unified naming conventions
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| main.go | Import new eventstoslice processor package |
| internal/processors/signalstoslice/signaltoslice.go | Fix package name and update processor registration name |
| internal/processors/eventstoslice/eventstoslice.go | Add new processor for converting events to slice format |
| internal/processors/dbmigration/processors.go | Update processor names with new naming conventions |
| go.mod | Update dependencies to newer versions |
| charts/dps/values.yaml | Add events topic configuration and unify database environment variables |
| charts/dps/templates/deployment.yaml | Dynamically mount stream files from streams directory |
| charts/dps/templates/configmap.yaml | Include streams directory in config map |
| charts/dps/files/streams/*.yaml | Update processor names and database references to use new conventions |
| Makefile | Update linting paths to reflect new stream organization |
Comments suppressed due to low confidence (1)
internal/processors/signalstoslice/signaltoslice.go:1
- The package name 'signaltoslice' should be 'signalstoslice' to match the directory name and be consistent with the plural naming convention used in 'eventstoslice'.
package signaltoslice
1c9b153 to
3d94c3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.