Merged
Conversation
elffjs
requested changes
Mar 12, 2025
| } | ||
|
|
||
| if err := d.cioService.SetEmail(ctx, acct.ID, normalEmail); err != nil { | ||
| if err := d.cioService.SetEmail(ctx, acct.ID, *userAccount.EthereumAddress, normalEmail); err != nil { |
Member
There was a problem hiding this comment.
We're creating the user, and we only have email, souserAccount.EthereumAddress is almost certainly nil and the handler will panic.
Member
There was a problem hiding this comment.
I think if you could guarantee that you'll never create an account with email first then we might be able to make this work. In fact, we would probably want to think about getting rid of this id KSUID altogether. Is this the case?
Member
There was a problem hiding this comment.
Okay, I'm looking at these lines. In the logs it seems like we always start with wallet:
I have no idea why the other path is there, then.
| } | ||
|
|
||
| func (c *Client) SetEmail(ctx context.Context, id, email string) error { | ||
| func (c *Client) SetEmail(ctx context.Context, id string, wallet common.Address, email string) error { |
| logger.Info().Msgf("Added unconfirmed email %s to account.", normalAddr) | ||
|
|
||
| if err := d.cioService.SetEmail(c.Context(), acct.ID, normalAddr); err != nil { | ||
| if err := d.cioService.SetEmail(c.Context(), acct.ID, *userAccount.EthereumAddress, normalAddr); err != nil { |
Member
There was a problem hiding this comment.
This has a better chance of not blowing up.
Guard against the (hopefully never-occurring) possibility that creation happens under an email JWT
elffjs
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.