[8.1] Parsing the jdl input by using the Job API#6300
Closed
simon-mazenoux wants to merge 1 commit intoDIRACGrid:integrationfrom
Closed
[8.1] Parsing the jdl input by using the Job API#6300simon-mazenoux wants to merge 1 commit intoDIRACGrid:integrationfrom
simon-mazenoux wants to merge 1 commit intoDIRACGrid:integrationfrom
Conversation
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
from
9487f9c to
fcb234d
Compare
fstagni
reviewed
Aug 15, 2022
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
5 times, most recently
from
7a7d58a to
0a821f0
Compare
aldbr
reviewed
Aug 31, 2022
fstagni
reviewed
Sep 2, 2022
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
from
0a821f0 to
dac20c9
Compare
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
from
dac20c9 to
644cfd2
Compare
simon-mazenoux
changed the title
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
from
644cfd2 to
1096dc8
Compare
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
from
1096dc8 to
ec513cc
Compare
DIRACGridBot
added
the
alsoTargeting:integration
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
4 times, most recently
from
5aa948b to
f407807
Compare
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
from
f407807 to
278b362
Compare
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
from
278b362 to
02957e1
Compare
simon-mazenoux
changed the title
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
from
02957e1 to
5d5c0db
Compare
aldbr
reviewed
May 23, 2023
docs/source/DeveloperGuide/AddingNewComponents/DevelopingInterfaces/index.rst
Outdated
Show resolved
Hide resolved
docs/source/DeveloperGuide/AddingNewComponents/DevelopingInterfaces/index.rst
Show resolved
Hide resolved
| "Extra JDL attribute parsed by the loadJDLasJob function", | ||
| ) | ||
|
|
||
| # TODO: Replace the two lines above by the following ones to let time for |
Contributor
There was a problem hiding this comment.
These lines should replace the above line from v8.2, shouldn't they?
You should probably change that in your documentation: https://github.com/DIRACGrid/DIRAC/pull/6300/files#diff-6d81cf9183302a57608464ac03712f23286f63667a7e7061cb79a3c9a164c3d7R94
Also, once merged, you can open an issue to remind us to make the change from v8.2.
| @@ -0,0 +1,156 @@ | |||
| # pylint: disable=protected-access,missing-docstring, invalid-name | |||
|
|
|||
| from unittest.mock import patch | |||
Contributor
There was a problem hiding this comment.
I think you can use the pytest mocker instead of the unittest one (see Test_HTCondorComputingElement).
To be checked.
| self.maxRescheduling = self.getCSOption("MaxRescheduling", 3) | ||
|
|
||
| # loading the function that will be used to determine the platform (it can be VO specific) | ||
| res = ObjectLoader().loadObject("ConfigurationSystem.Client.Helpers.Resources", "getDIRACPlatform") |
| if value is None: | ||
| value = jobDescription.getAttributeFloat(attribute) | ||
| if value is None: | ||
| value = jobDescription.get_expression(attribute) |
Contributor
There was a problem hiding this comment.
Do we need this line here?
Suggested change
| value = jobDescription.get_expression(attribute) |
simon-mazenoux
force-pushed
the
feat-parsing-the-jdl-file-into-a-job-object
branch
from
5d5c0db to
e7b84eb
Compare
Contributor
|
As discussed: not for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*API
NEW: JDLs are now parsed using the Job API
ENDRELEASENOTES