Skip to content

[v8r0] Fix MySQL Optimizer and don't start JobAgent for integration tests#6411

Merged
fstagni merged 2 commits into
DIRACGrid:rel-v8r0from
chaen:rel-v8r0_fix_optimizerAndTests
Oct 13, 2022
Merged

[v8r0] Fix MySQL Optimizer and don't start JobAgent for integration tests#6411
fstagni merged 2 commits into
DIRACGrid:rel-v8r0from
chaen:rel-v8r0_fix_optimizerAndTests

Conversation

@chaen

@chaen chaen commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

This reduces the execution time by 8mn. The server installation is installing the JobAgent as a "normal" agent, which of course does not make sense

2022-10-12 16:03:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] INFO: MatcherTime = 0.04 (s)
2022-10-12 16:03:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] NOTICE: Failed to get jobs Error requesting job
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] NOTICE: ----------------------------------------
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] NOTICE: Agent module WorkloadManagement/JobAgent run summary
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] NOTICE:  Executed 1 times previously
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] NOTICE:  Cycle took 480.13 seconds
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] NOTICE:  Average execution time: 480.13 seconds
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent [140224882960128] DEBUG: Refreshing configuration...
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] NOTICE:  Polling time: 120 seconds
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] NOTICE:  Average execution/polling time: 400.11%
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] NOTICE:  Cycle was successful
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent/WorkloadManagement/JobAgent [140224957937472] NOTICE: ----------------------------------------
2022-10-12 16:11:12 UTC WorkloadManagement/JobAgent [140224957937472] INFO: No more agent modules to execute. Exiting

Also, it fixes the MySQL tracer I've introduced. I have absolutely no idea how I got it working last time...

BEGINRELEASENOTES
*Test
FIX: server installation do not install JobAgent

*Core
FIX: MySQL tracer bugs

ENDRELEASENOTES

@chaen chaen requested review from atsareg and fstagni as code owners October 13, 2022 05:56
@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Oct 13, 2022

@fstagni fstagni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well JobAgent is a "real" agent but it is not something to start on server side.

@fstagni fstagni merged commit 262ef12 into DIRACGrid:rel-v8r0 Oct 13, 2022
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Oct 13, 2022
@DIRACGridBot

Copy link
Copy Markdown

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/3240422603

Failed:

  • integration
    cherry-pick 262ef12 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-262ef120a-integration
    git cherry-pick -x -m 1 262ef120a
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #6411 Fix MySQL Optimizer and don'"'"'t start JobAgent for integration tests' --author='chaen <christophe.haen@cern.ch>'
    git push -u origin cherry-pick-2-262ef120a-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] Fix MySQL Optimizer and don'"'"'t start JobAgent for integration tests' \
         --body 'Sweep #6411 `Fix MySQL Optimizer and don'"'"'t start JobAgent for integration tests` to `integration`.
    
    Adding original author @chaen as watcher.
    
    BEGINRELEASENOTES
    *Test
    FIX: server installation do not install JobAgent
    
    *Core
    FIX: MySQL tracer bugs
    
    ENDRELEASENOTES
    Closes #6413'

chrisburr pushed a commit to chrisburr/DIRAC that referenced this pull request Oct 17, 2022
simon-mazenoux pushed a commit to simon-mazenoux/DIRAC that referenced this pull request May 24, 2023
simon-mazenoux pushed a commit to simon-mazenoux/DIRAC that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants